Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falende stickey-pull-request-comment integration #79

Closed
floort opened this issue Apr 4, 2024 · 4 comments
Closed

Falende stickey-pull-request-comment integration #79

floort opened this issue Apr 4, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@floort
Copy link
Contributor

floort commented Apr 4, 2024

Describe the bug
It appears that pull request from people without commit access to this repo get a the following error on a github action that blocks the pull request:
Run marocchino/sticky-pull-request-comment@331f8f5b4215f0445d3c07b4967662a32a2d3e31 Error: Resource not accessible by integration

To Reproduce
Steps to reproduce the behavior:

  1. As someone without commit acces: create a fork
  2. Make some changes to the fork an submit a pull request
  3. Observe the above error

Expected behavior
No error

Screenshots
Screenshot 2024-04-04 at 14 18 28

Additional context
Issue seems to be known by @berrydenhartog in a comment that is now removed from #72. Posting it here as a bug report as it's undocumented now.

@berrydenhartog
Copy link
Member

@floort. This is indeed the case but is does not block the PR. The PR is only blocked by no approving reviews yet.

The reason the action fails is because of this github action that tries to deploy a version of a PR to the website for review:

uses: rossjrw/pr-preview-action@v1

This issue is described in the github action as a known problem.

This Action does not currently support deploying previews for PRs from forks, but will do so in rossjrw/pr-preview-action#6.

We could solve it by not running the action for forked repos

@floort
Copy link
Contributor Author

floort commented Apr 4, 2024

Good to hear that it's not a blocking issue.

P.S. I noticed I'm switching between English and Dutch. Here the bug report template is English so I stuck to that without thinking about it. What's the preferred language for contributions?

@ruthkoole ruthkoole added the bug Something isn't working label Apr 10, 2024
@ruthkoole
Copy link
Collaborator

Zowel Nederlands als Engels is goed om een issue te melden. Het algoritmekader is in het Nederlands, daarom lijkt Nederlands logischer. Maar de bugs zijn in het Engels, waardoor dat ook een logische keuze is.

Vervelend dat dit leidt tot een error.

@berrydenhartog kan jij kijken of we deze functionaliteit uit kunnen zetten voor forked repo's?

@berrydenhartog
Copy link
Member

@ruthkoole. Ik zal de github action uitzetten voor forked repos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants