WIP: convert test-translate-package to snapshots #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a dead end pending r-lib/testthat#1484... |
MichaelChirico
commented
Nov 9, 2021
| expect_match(prompts, "a similar message was previously translated as", all=FALSE) | ||
| }) | ||
| with_restoration_test_that("translate_package works on a simple package w/o translating", "r_msg", { | ||
| mockery::stub(translate_package, "get_atime", "0000-01-01 00:00:00") |
There was a problem hiding this comment.
@hadley I couldn't seem to make mockery::stub work inside with_restoration_test_that, are you familiar enough with whether that's possible?
|
Current failure: It appears the gettext tool is producing a differing number of |
|
The joys of snapshot testing! |
|
quite a pain but the test file will be sooo much cleaner if it can work, so not giving up just yet |
MichaelChirico
added a commit
that referenced
this pull request
Nov 11, 2021
…235) * Implement tr_add() for adding new translations * Add or update as necessary * Only add previous for tr_add() * Fix typo * Split tr_add() into po_create() and po_update() * lang->languages * lang->languages * Mark .pot file as UTF-8 * Split po_create() and po_update() into pieces And fundamentally change approach * Fix broken tests * Add test for po_create() Bringing in system2() code from #257 * WS * Extract out local_test_package() helper * Extract & test po_language_files() * Add tests for create and update And fix the bugs thus revealed * Add missing line * might as well use fifelse * Add links to solaris docs * Revert unintentional change * Move local_test_package() to better home * Revert CHARSET -> UTF-8 change * More docs about updating * Standardise number of dots * Improve docs * Tweak messaging * Revert accidental doc changes * add TODO * another TODO * typo * clarify fuzzy description * comment need for standardise_dots & americanize 🇺🇸 Co-authored-by: Michael Chirico <[email protected]>
|
Lots of fun with encoding on Windows :) And the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #256