Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a mark in the chart when the product has a "event". #10

Open
drielnox opened this issue Sep 5, 2017 · 2 comments
Open

Add a mark in the chart when the product has a "event". #10

drielnox opened this issue Sep 5, 2017 · 2 comments

Comments

@drielnox
Copy link

drielnox commented Sep 5, 2017

This event its related when the product:

  • has a new discount.
  • has a new price.
  • warranty its changed.
  • description its changed.
  • payment method its changed.
  • etc.

This idea is picked from finance.google.com indexes. The indexes have a mark when a new novelty(news) appear related to that index. For example, check it out Merval's Index.

@GMaiolo
Copy link
Member

GMaiolo commented Sep 6, 2017

We're already tracking for a new price, and a new "discount" is pretty much tied to that.
Regarding tracking the description, that may be a little hard because it's not easy to show those kind of changes within the extension and there would be too many edge cases (what would happen if a user completely rewrites 90% of the description, how do we show that?).
We could start tracking payment methods / warranties, I haven't thought of that and it seems a good idea, although I don't know if the later is provided by MLibre's API, if it is then it would be completely possible.
How do you imagine these being displayed?

(Podemos hablar en español si querés, no hay problema)

@drielnox drielnox changed the title Add a mark in the chart when in the product has a event. Add a mark in the chart when the product has a "event". Sep 7, 2017
@drielnox
Copy link
Author

drielnox commented Sep 7, 2017

@GMaiolo con respecto a la descripción, tenes razon que seria dificil hacer un seguimiento. Ya el hecho de pensar en hacer un diff(a la git) entre la vieja y nueva descripción de un texto de más de 1000 palabras, sería molesto hasta para verlo.

En cuanto a los métodos de pagos, como están fijados por ML, debe ser un enumerado con un máximo de 10 opciones(dicho exageradamente). La garantía es un texto corto de 2 renglones. Por lo general, la garantía, suele ser muy concisa.

Y como me imagino esto... Lo haría exactamente como Google Finance. En el chart pondría como una especie de PIN que hace referencia al evento en particular. El chart lo pondría en un Tab y pondría otro tab para poner los eventos de manera detallada. Ejemplo:

fecha hora tipo_evento cambio
10-10-2010 12:00 garantia 3 meses
15-10-2010 14:00 garantia 6 meses
17-10-2010 14:00 metodoPago efectivo+transBanca
15-11-2010 14:00 garantia 12 meses
1-12-2010 14:00 metodoPago mercadoPago

Seria como una idea re preliminar... pero con el tiempo se puede ir puliendo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants