Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disable double notification when receiving a Kudos - MEED-1650 - Meeds-io/meeds#576 #317

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

boubaker
Copy link
Member

This change will allow to reuse Activity Notifications for Kudos Activities and comment but not for the receiver who will get one single specific notification.

…Meeds-io/meeds#576 (#315)

This change will allow to reuse Activity Notifications for Kudos Activities and comment but not for the receiver who will get one single specific notification.
@boubaker boubaker requested a review from AzmiTouil July 27, 2023 12:36
@boubaker boubaker enabled auto-merge (squash) July 27, 2023 13:05
@boubaker boubaker disabled auto-merge July 27, 2023 13:05
@boubaker boubaker enabled auto-merge (squash) July 27, 2023 13:05
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

34.0% 34.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@boubaker boubaker merged commit c259fc1 into develop Jul 27, 2023
2 of 3 checks passed
@boubaker boubaker deleted the meed-1650-develop branch July 27, 2023 13:49
exo-swf pushed a commit that referenced this pull request Jul 27, 2023
…Meeds-io/meeds#576 (#317)

This change will allow to reuse Activity Notifications for Kudos Activities and comment but not for the receiver who will get one single specific notification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants