From 6e467a9d3736e67d92a9343c714d9c83ac03b4ae Mon Sep 17 00:00:00 2001 From: Boubaker Khanfir Date: Tue, 18 Jul 2023 13:27:59 +0100 Subject: [PATCH 1/2] feat: Add Attach images integration to Kudos - MEED-2034 - Meeds-io/MIPs#53 --- .../vue-app/kudos/components/KudosApp.vue | 21 +++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/kudos-webapps/src/main/webapp/vue-app/kudos/components/KudosApp.vue b/kudos-webapps/src/main/webapp/vue-app/kudos/components/KudosApp.vue index 06e1a1185..941f530d3 100644 --- a/kudos-webapps/src/main/webapp/vue-app/kudos/components/KudosApp.vue +++ b/kudos-webapps/src/main/webapp/vue-app/kudos/components/KudosApp.vue @@ -72,15 +72,18 @@ {{ $t('exoplatform.kudos.title.message') }}
-
@@ -147,6 +150,7 @@ export default { entityOwner: '', receiverType: null, receiverId: null, + metadataObjectId: null, error: null, drawer: false, MESSAGE_MAX_LENGTH: 1300, @@ -275,7 +279,10 @@ export default { }, typeOfRelation() { return this.isLinkedKudos ? 'mention_comment' : 'mention_activity_stream'; - } + }, + ckEditorType() { + return this.isLinkedKudos ? 'activityComment' : 'activityContent'; + }, }, methods: { init() { @@ -304,7 +311,7 @@ export default { resetEditor() { this.$refs[this.ckEditorId].destroyCKEditor(); }, - initDrawer () { + initDrawer() { this.kudosMessage = ''; this.kudosToSend = null; this.error = null; @@ -401,6 +408,7 @@ export default { this.entityType = event && event.detail && event.detail.type; this.entityId = event && event.detail && event.detail.id; + this.metadataObjectId = null; this.entityOwner = event && event.detail && event.detail.owner; this.parentEntityId = event && event.detail && event.detail.parentId; this.ignoreRefresh = event && event.detail && event.detail.ignoreRefresh; @@ -441,7 +449,12 @@ export default { if (!kudosSent) { throw new Error(this.$t('exoplatform.kudos.error.errorSendingKudos')); } + this.metadataObjectId = this.isLinkedKudos && `comment${kudosSent.activityId}` || `${kudosSent.activityId}`; document.dispatchEvent(new CustomEvent('exo-kudos-sent', {detail: kudosSent})); + return this.$nextTick(); + }) + .then(() => this.$refs[this.ckEditorId].saveAttachments()) + .then(() => { return this.init() .catch(e => { console.error('Error refreshing allowed number of kudos for current user', e); From d6ca6c7c6170cd7d087e81fb5856cd1f16650cbe Mon Sep 17 00:00:00 2001 From: Boubaker Khanfir Date: Tue, 18 Jul 2023 13:46:37 +0100 Subject: [PATCH 2/2] Retrieve Activity Id right away after kudos creation --- .../org/exoplatform/kudos/listener/KudosActivityListener.java | 2 +- .../main/java/org/exoplatform/kudos/service/KudosService.java | 2 +- kudos-webapps/src/main/webapp/WEB-INF/gatein-resources.xml | 3 +++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/kudos-services/src/main/java/org/exoplatform/kudos/listener/KudosActivityListener.java b/kudos-services/src/main/java/org/exoplatform/kudos/listener/KudosActivityListener.java index bb775e164..8fe1cb060 100644 --- a/kudos-services/src/main/java/org/exoplatform/kudos/listener/KudosActivityListener.java +++ b/kudos-services/src/main/java/org/exoplatform/kudos/listener/KudosActivityListener.java @@ -39,7 +39,7 @@ public void saveActivity(ActivityLifeCycleEvent activityLifeCycleEvent) { @Override public void updateActivity(ActivityLifeCycleEvent activityLifeCycleEvent) { ExoSocialActivity activity = activityLifeCycleEvent.getSource(); - if (activity.getType().equals(KUDOS_ACTIVITY_COMMENT_TYPE)) { + if (activity != null && activity.getType().equals(KUDOS_ACTIVITY_COMMENT_TYPE)) { long activityId = org.exoplatform.kudos.service.utils.Utils.getActivityId(activity.getId()); Kudos kudos = kudosService.getKudosByActivityId(activityId); if (kudos != null) { diff --git a/kudos-services/src/main/java/org/exoplatform/kudos/service/KudosService.java b/kudos-services/src/main/java/org/exoplatform/kudos/service/KudosService.java index 6c99aa6ab..7b38185b8 100644 --- a/kudos-services/src/main/java/org/exoplatform/kudos/service/KudosService.java +++ b/kudos-services/src/main/java/org/exoplatform/kudos/service/KudosService.java @@ -209,7 +209,7 @@ public Kudos createKudos(Kudos kudos, String currentUser) throws Exception { listenerService.broadcast(KUDOS_SENT_EVENT, this, createdKudos); - return createdKudos; + return kudosStorage.getKudoById(createdKudos.getTechnicalId()); } /** diff --git a/kudos-webapps/src/main/webapp/WEB-INF/gatein-resources.xml b/kudos-webapps/src/main/webapp/WEB-INF/gatein-resources.xml index 9ba78ded7..d042c8ae1 100644 --- a/kudos-webapps/src/main/webapp/WEB-INF/gatein-resources.xml +++ b/kudos-webapps/src/main/webapp/WEB-INF/gatein-resources.xml @@ -119,6 +119,9 @@ extensionRegistry + + attachImage +