Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portlet UI Cleanup #81

Closed
srenault-meeds opened this issue Sep 5, 2023 · 15 comments
Closed

Portlet UI Cleanup #81

srenault-meeds opened this issue Sep 5, 2023 · 15 comments

Comments

@srenault-meeds
Copy link
Collaborator

srenault-meeds commented Sep 5, 2023

Rationale

UI Theme used to display informations needs to be reviewed a bit to make sure we have consistencies between portlets: border, display of title, subtitle, body (padding, font-size, text-transform)
For example, in the stream page, we have:

  • Your activity or Activity stream which is displayed differently than other portlet titles
  • Border-radius have been applied to some portlet (composer, contributions) but not others
  • Uppercase is applied to titles and some are forced as is
image

1. Functional Requirements

1. Functional Requirements

Top User Stories

Each time we add a new portlet, these characteristics below must be considered.

  1. Portlet padding/margin characteristics UI
  • Any existing portlet must be displayed with a border-radius of 8px (by default)
  • Padding inside needs to be 20px 
  • Margin-bottom (external) must be 20px. Other margins will be dealt by container
  • Contents inside the portlet needs to be displayed as left aligned AND with margin depending what to display:
    a. title (if not only a title): padding: 0 0 20px 0
    b. subtitle (if something below): padding: 0 0 16px 0
    c. subtitle (if body above): padding: 20px 0 16px 0
    d. Body (until there are other items to list): padding: 0 0 16px 0
  1. Portlet text styles

Ideally, portlet will have same styles and adding a class for each would be a good way to ensure consistency and reusability. Below, characteristics of each content:

Title:

  • Font-size: 18px
  • No text-transformation (no uppercase). If needed, labels can be updated from Crowdin
  • Font-color: allPagesGreyColorLighten1,#707070
  • Font-style: regular

See more:

  • Font-size: 14px
  • Font-color: primary color
  • Font-style: regular

Subtitle:

  • Font-size: 16px
  • Font-color: --allPagesBaseTextColor: #20282c;
  • Font-style: regular

body main text:

  • Font-size: 14px
  • Font-color: --allPagesBaseTextColor: #20282c;
  • Font-style: regular

body subtitle:

  • Font-size: 14px
  • Font-color: --allPagesGreyColorLighten1: #707070;
  • Font-style: regular

Example:
image

Detail of padding/margin:
portlet review - details

Impacts

Any existing portlet must be updated to get those characteristics applied
Provide a reusable component so the portlet is still used when adding a new portlet

2. Technical Requirements

Extensibility

Like the drawers, the widgets has to define a single template to reuse for all existing widgets with centralized styled title, borders and margins.

4. Software Architecture

Access 

We have to use the same manner as overview banner and drawer to define generic and reusable style for widgets. Please refer to Widget.vue to take an example of using slots for overview page.

PS: no specific stylesheet has to be added for this reusable component.

@srenault-meeds srenault-meeds changed the title DRAFT - Portlet UI Cleanup Portlet UI Cleanup Sep 6, 2023
@srenault-meeds
Copy link
Collaborator Author

Ready for review @margondicco
cc @Julien-Dubois-eXo if you want to take a look as well

@srenault-meeds
Copy link
Collaborator Author

Ready for review please @margondicco

@margondicco
Copy link

Perfect Go fonc

@srenault-meeds
Copy link
Collaborator Author

Thanks. Ready for tech spec @boubaker

@boubaker
Copy link
Member

ok, thanks, Ready for Tec Review @rdenarie

@SaraBoutej FYI.

@rdenarie
Copy link
Member

👍 go tech

SaraBoutej added a commit to Meeds-io/gatein-portal that referenced this issue Oct 10, 2023
SaraBoutej added a commit to Meeds-io/platform-ui that referenced this issue Oct 10, 2023
SaraBoutej added a commit to Meeds-io/gatein-portal that referenced this issue Oct 10, 2023
SaraBoutej added a commit to Meeds-io/platform-ui that referenced this issue Oct 11, 2023
SaraBoutej added a commit to Meeds-io/platform-ui that referenced this issue Oct 11, 2023
SaraBoutej added a commit to Meeds-io/social that referenced this issue Oct 11, 2023
…-io/MIPs#81 (#3022)

This PR allows to add new reusable component to define a unique ui/ux for all the widget the platform
exo-swf pushed a commit to Meeds-io/gatein-portal that referenced this issue Oct 12, 2023
exo-swf pushed a commit to Meeds-io/analytics that referenced this issue Nov 14, 2023
exo-swf pushed a commit to Meeds-io/gamification that referenced this issue Nov 14, 2023
…s#81

(cherry picked from commit ffe643f)
(cherry picked from commit 436ce00)
exo-swf pushed a commit to Meeds-io/gamification that referenced this issue Nov 14, 2023
…s#81 (#1254)

Fix feedback

(cherry picked from commit 7ae79fb)
(cherry picked from commit 70e2e14)
exo-swf pushed a commit to Meeds-io/gamification that referenced this issue Nov 14, 2023
exo-swf pushed a commit to Meeds-io/gamification that referenced this issue Nov 14, 2023
exo-swf pushed a commit to Meeds-io/gamification that referenced this issue Nov 14, 2023
…/MIPs#81 (#1289)

This PR allows to hide placeholder on the reward overview portlet when loading

(cherry picked from commit cf15e22)
exo-swf pushed a commit to Meeds-io/kudos that referenced this issue Nov 14, 2023
 (#398)

This change allows to add the brandable border radius to analytics app

(cherry picked from commit 0277e9d)
(cherry picked from commit 60a837d)
exo-swf pushed a commit to Meeds-io/kudos that referenced this issue Nov 14, 2023
…402)

(cherry picked from commit 18c415c)
(cherry picked from commit 321c421)
exo-swf pushed a commit to Meeds-io/kudos that referenced this issue Nov 14, 2023
…#403)

(cherry picked from commit 58553a0)
(cherry picked from commit 5e0bd66)
exo-swf pushed a commit to Meeds-io/kudos that referenced this issue Nov 14, 2023
…s#81 (#410)

Prior to this change open a kudos list is not possible in the profile page and in the overview page.
This change allows to put the drawer of the kudos list in the reusable components kudos-overview-row , thus, we can open the drawer of the kudos list.

(cherry picked from commit 4df32de)
exo-swf pushed a commit to Meeds-io/perk-store that referenced this issue Nov 14, 2023
…eds-io/MIPs#81 (#279)

This changes is about adding the new brandable border radius to the perkstore overview widget.

(cherry picked from commit c7982d6)
(cherry picked from commit a97d189)
exo-swf pushed a commit to Meeds-io/perk-store that referenced this issue Nov 14, 2023
…280)

(cherry picked from commit d9e0175)
(cherry picked from commit 756d806)
exo-swf pushed a commit to Meeds-io/wallet that referenced this issue Nov 14, 2023
…s#81  (#432)

This PR adds the new brandable border radius to all the wallet apps

(cherry picked from commit f3b6fec)
exo-swf pushed a commit to Meeds-io/poll that referenced this issue Nov 14, 2023
#114)

This change allows to add the brandable border radius to the task dashboard

(cherry picked from commit 1552427)
exo-swf pushed a commit to Meeds-io/app-center that referenced this issue Nov 14, 2023
… (#282)

This change adds the new brandable border radius to the app admin application

(cherry picked from commit 41abeef)
(cherry picked from commit 9f4e379)
exo-swf pushed a commit to Meeds-io/app-center that referenced this issue Nov 14, 2023
(cherry picked from commit 22439b1)
(cherry picked from commit b65217e)
exo-swf pushed a commit to Meeds-io/task that referenced this issue Nov 14, 2023
 (#287)

This change allows to add the brandable border radius to the task dashboard

(cherry picked from commit 8f2a92f)
exo-swf pushed a commit to Meeds-io/task that referenced this issue Nov 14, 2023
exo-swf pushed a commit to Meeds-io/task that referenced this issue Nov 14, 2023
…/MIPs#81 (#296)

fix feedback

(cherry picked from commit 5eaa3a2)
(cherry picked from commit 16f1a39)
exo-swf pushed a commit to Meeds-io/meeds-qa-ui that referenced this issue Nov 14, 2023
exo-swf pushed a commit to Meeds-io/meeds-qa-ui that referenced this issue Nov 15, 2023
…s#81 (#215)

This will ignore Failed Test Cases on CI/CD. This change will be
reverted once the Tests are fixed.
rdenarie added a commit to exoplatform/digital-workplace that referenced this issue Nov 15, 2023
Before this fix, the new branding settings (radius) cannot be saved in interface
This is due to the override of the BrandingService configuration file
Then the new property about radius was not added on our side.
This commit add the property
rdenarie added a commit to exoplatform/digital-workplace that referenced this issue Nov 15, 2023
Before this fix, the new branding settings (radius) cannot be saved in interface
This is due to the override of the BrandingService configuration file
Then the new property about radius was not added on our side.
This commit add the property
SaraBoutej added a commit to Meeds-io/platform-ui that referenced this issue Nov 21, 2023
SaraBoutej added a commit to Meeds-io/platform-ui that referenced this issue Nov 21, 2023
SaraBoutej added a commit to Meeds-io/platform-ui that referenced this issue Nov 21, 2023
SaraBoutej added a commit to Meeds-io/wallet that referenced this issue Nov 21, 2023
…s#81  (#432)

This PR adds the new brandable border radius to all the wallet apps

(cherry picked from commit f3b6fec)
exo-swf pushed a commit to Meeds-io/meeds-qa-ui that referenced this issue Nov 22, 2023
…s#81 (#215)

This will ignore Failed Test Cases on CI/CD. This change will be
reverted once the Tests are fixed.
@boubaker boubaker added this to the 1.5.0-M18 milestone Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

No branches or pull requests

6 participants