Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcode sends too fast #236

Open
i-make-robots opened this issue Jan 7, 2024 · 1 comment
Open

gcode sends too fast #236

i-make-robots opened this issue Jan 7, 2024 · 1 comment
Labels

Comments

@i-make-robots
Copy link
Collaborator

Describe the bug
GCode can be sent from the app to a marlin device too fast. messages might be lost, out of order, or garbled by transmit failure.
There is no receipt system. There is no system to queue, resend, and CRC check messages.

To Reproduce
Steps to reproduce the behavior:

  1. Make some gcode
  2. connect to the robot
  3. send too much gcode too fast.

Expected behavior
Marlin sends "OK" when it is ready for more. do not send more until OK received.
Problem is already well-solved in Makelangelo-software and in RO2.
Implement the solution from there.

Probably requires #234 first.

@i-make-robots
Copy link
Collaborator Author

Presently gcode sending is controlled by the speed of the EditorPanel. rate limiting is a little better, but still not a thorough solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant