Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The module does not comply with the latest developer guide #17

Open
crok opened this issue Mar 13, 2020 · 2 comments
Open

The module does not comply with the latest developer guide #17

crok opened this issue Mar 13, 2020 · 2 comments

Comments

@crok
Copy link

crok commented Mar 13, 2020

Hi,

Please review the structure of the module and

  • remove the install.sh file and move the customisation implemented in it to customize.sh (eg. installation banner)
  • remove the common directory from the root of the module, all files are safe to delete

Please check the developer guide for more info.

Thanks!
@AvinashReddy3108
Copy link
Collaborator

Thanks for letting us know of this, we are working on a total rewrite of the module right now and will update the script along with the new template guidelines soon.

@crok
Copy link
Author

crok commented Mar 13, 2020

You're welcome and thank you for the info, then I'm waiting for the upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crok @AvinashReddy3108