Please provide a short description of the change or if the change is sufficiently described in the GitHub issue, provide a link to the issue.
Please describe the test strategy you followed.
- automated unit test
- automated integration test
- automated acceptance test
- manual, exploratory test
In case of manual test, please document the test well including a set of user instructions and prerequisites. Each including an action, it's result, and where appropriate a screenshot.
- My code follows the coding guidelines of this project
- I have performed a self-review of my code
- I have commented my code, particularly in hard-to-understand areas
- My code fulfilles all acceptance criteria
- I have added tests that prove my fix is effective or that my feature works
- New and existing unit tests pass locally with my changes
- I have made corresponding changes to the documentation
- I have added explanation of architectural decision and rationales to wiki/adr
- I have updated the changes in the ticket description
- The code works and does not throw errors
- The code is easy to understand and there are no confusing parts
- The code follows the coding guidelines of this project
- The code change accomplishes what it is supposed to do
- I cannot think of any use case in which the code does not behave as intended
- The added and existing tests reasonably cover the code change
- I cannot think of any test cases, input or edge cases that should be tested in addition
- Description of the change is included in the documentation