Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node version is not specified on DDEV defaults to 20 on local and 18 on Tugboat #620

Open
beto-aveiga opened this issue Jul 23, 2024 · 4 comments

Comments

@beto-aveiga
Copy link
Collaborator

When the node version is not specific on the .ddev/config.yml file, it defaults to 20 locally on DDEV, but on Tugboat, it is 18.

Then after running composer install with the node version set on the DDEV config file, you get an update in the init.sh for tugboat

image

Which means that node version is not sync locally and for Tugboat.

@deviantintegral
Copy link
Member

What's interesting is the default config ddev generates has a node version in it. So I guess it would have been manually deleted?

I think it would be fine for us to throw an error if the node version isn't specified in ddev.

@beto-aveiga
Copy link
Collaborator Author

What's interesting is the default config ddev generates has a node version in it. So I guess it would have been manually deleted?

Likely yes.

I think it would be fine for us to throw an error if the node version isn't specified in ddev.

@deviantintegral What about just throwing a warning?

@deviantintegral
Copy link
Member

Why would you want to not specify the node version? At the least, I would have thought you'd want "auto" (which admittedly our Tugboat config won't do anything with).

https://ddev.readthedocs.io/en/stable/users/configuration/config/#nodejs_version

@beto-aveiga
Copy link
Collaborator Author

I think about projects that do not have this for any reason, and then Drainpipe stop working when running composer install or when trying to deploy a Tugboat instance. A warning seems better than breaking a packages installation or breaking a deployment on Tugboat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants