Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git status check as a build step #396

Closed
mrdavidburns opened this issue Feb 5, 2024 · 2 comments
Closed

git status check as a build step #396

mrdavidburns opened this issue Feb 5, 2024 · 2 comments

Comments

@mrdavidburns
Copy link
Member

In most cases we would want no file differences before and after a pull request builds a project. Running git status should show any files that do not match changes committed to the repository.

  1. Do we block the PR from being merged?
  • It may be intentional that we're not committing all changes from composer install. For example Drainpipe may have customized changes inside the .tugboat/scripts which a developer doesn't want to commit to the project.
@justafish
Copy link
Member

Duplicate of #247

@justafish justafish marked this as a duplicate of #247 Feb 15, 2024
@deviantintegral
Copy link
Member

The issue is #225 .

@deviantintegral deviantintegral closed this as not planned Won't fix, can't repro, duplicate, stale Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@deviantintegral @mrdavidburns @justafish