Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: (Re-)Expose user setting for the number of views #40

Open
tbirdso opened this issue Oct 26, 2023 · 1 comment
Open

Comments

@tbirdso
Copy link

tbirdso commented Oct 26, 2023

Description

In the 0.3.0 release it was possible to set the number of views to render on the Looking Glass display via a UI slider. That feature was useful for managing the tradeoff between performance and fidelity for large, complex, or otherwise demanding datasets.

In 0.4.0 it appears that user setting is no longer exposed through the public API (https://github.com/Looking-Glass/looking-glass-webxr/blob/main/src/LookingGlassConfig.ts#L162) and is instead set under the hood to a constant number of views to make up the quilt. Due to import/namespace changes from 0.3.0 to 0.4.0 it appears to be difficult to swap versions in and out in a consuming project.

Feature Request

As a minimum goal, it would be nice for numViews to be exposed through the public API again for programmatic adjustment during ongoing rendering.

As a stretch goal, it would be useful for a UI slider to be added back to adjust this value.

@BryanChrisBrown
Copy link
Collaborator

re-added this value in this PR #45

UI slider is definitely possible to add again as well, I recently pushed up another PR with improved UI for the settings panel, I'll see if I can make that more configurable to allow for custom UI elements to be chosen via the config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants