[Bug]: Inconsistent behavior on undefined post langagues during creation vs editing

[Nothing4You]

Requirements

• Is this a bug report? For questions or discussions use https://lemmy.ml/c/lemmy_support
• Did you check to see if this issue already exists?
• Is this only a single bug? Do not put multiple bugs in one issue.
• Do you agree to follow the rules in our Code of Conduct?
• Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.

Summary

Start by having no intersection in community allowed languages and user languages or two or more non-undetermined languages as intersection. The test community must not have Undetermined as allowed language.

When creating a new post, for example in Lemmy-UI, no language id is passed in the request body if no language is selected by the user.
Lemmy first checks if the provided language is acceptable. If no language is provided, this check simply returns success.
Next, Lemmy will determine the default post language to use. It will query the community languages and user languages and use the intersection if there is a single language that is not Undetermined or the non-undetermined language if the intersection is Undetermined and one other language. If no language could be found, the language id will not be passed to the DB and the column default of 0, which maps to Undetermined.
Based on this logic, it is clear that it should always be possible to create a post with Undetermined language.

When updating the post however, Lemmy-UI explicitly includes the Undefined as language id. Since this was returned by the server, it should be safe to assume that a post could be saved with the same value again, but Lemmy now raises a LanguageNotAllowed error.
The logic to update a post is quite similar to the creation, although the fallback to determine a default language is not present. Instead, this only checks if the provided language id, if one is provided, is allowed in the community.
Unlike during post creation, Lemmy-UI will now send the language id previously provided by the server, and the Undetermined language will now fail the test. This time the check will fail, as Undetermined is not None, and Undetermined is not an allowed language in the community.

What do you think about just updating is_allowed_community_language() to always return Ok(()) when for_language_id is UNDETERMINED_ID?

Steps to Reproduce

1. Set community languages to Afaraf and avesta
2. Set user language to Afrikaans
3. Create post without selecting a language

{"name":"testfoo","community_id":1510682,"nsfw":false}

4. Try editing the post without changing the language

{"post_id":2083355,"name":"testfoo","body":"1","nsfw":false,"language_id":0}

5. Receive

{"error":"language_not_allowed"}

Technical Details

see above

Version

0.19.6-beta.4

Lemmy Instance URL

voyager.lemmy.ml

[Nutomic]

This looks like a problem in lemmy-ui. When creating a new post with no language selected, it doesnt send any language_id value. But when editing a post, also with no language selected, it sends language_id: 0 which fails a backend check. So it should be consistent and leave out language_id in both cases.

[Nothing4You]

A counterargument could be that the post is automatically set to language_id: 0.
Would it be unreasonable to expect that a value in an edit body, which is equal to the current DB value, is valid?

[Nutomic]

Alright I made a change in #5132, so it always assigns a default language if language id is 0 or null and checks if the language is valid after that. In my testing I couldnt reproduce your problem anymore, can you also give it a try?