Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] T.H Prevents drawing on some scenes. #88

Open
TheForlornKnight opened this issue Jan 16, 2022 · 6 comments
Open

[BUG] T.H Prevents drawing on some scenes. #88

TheForlornKnight opened this issue Jan 16, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@TheForlornKnight
Copy link

TheForlornKnight commented Jan 16, 2022

Module Version: v0.8.33

Describe the bug
After most recent Foundry & Pathfinder 2e updates, Trigger Happy is preventing me from using any drawing type tools on some scenes. This includes Drawing, Placing Tokens, and using Area Effect Rulers.

To Reproduce
Steps to reproduce the behavior:

  1. Disable Trigger Happy
  2. Using a PDF importer (like PDF to Foundry), create a scene by importing a map. I am using the Fish Camp from Troubles in Otari.
  3. Attempt to place a Token, Draw a Circle, and place a Cone area effect. All should work as intended.
  4. Enable Trigger Happy.
  5. Return to scene and attempt to place a Token, Draw a Circle, and place a Cone area effect. Nothing will appear and no outline box will follow cursor. Previously placed Objects will still be present, selectable, and editable.
  6. Create a new Scene with a blank background.
  7. Attempt to place a Token, Draw a Circle, and place a Cone area effect. All should work as intended.

Expected behavior
Drawn objects such as Tokens, Shapes, and Area effects should all function regardless of the scene.

Screenshots
Video of Issue Here

Browser:

  • Firefox

Foundry Version:
-Version 9, Build 242

Game System:

  • Pathfinder 2nd Edition 3.2.0.9965

Additional context

@TheForlornKnight TheForlornKnight added the bug Something isn't working label Jan 16, 2022
@p4535992
Copy link
Collaborator

any error on the web console (the F12 button) ?

@p4535992
Copy link
Collaborator

it's seem connected to the last bug of foundry:
https://gitlab.com/foundrynet/foundryvtt/-/issues/6465
can you try to disable the module setting : Enable avoid to deselect elements on the trigger event
If the error persist is a new logic on foundry 9.242

@TheForlornKnight
Copy link
Author

Enable avoid to deselect elements on the trigger event DONE, no change, so guess it is Foundry.

Errors are numerous, all tied to something my landing page is trying to do with Trigger Happy. Included just FYI. Thanks the help.

trigger-happy | Can't retrieve the config with entity 'token' and key 'Home' or 'undefined' on '@token[Home]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key 'Characters Home' or 'undefined' on '@token[Characters Home]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key 'Otari Home' or 'undefined' on '@token[Otari Home]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key 'AV Home' or 'undefined' on '@token[AV Home]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key 'TiO Home' or 'undefined' on '@token[TiO Home]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key 'Characters Journal' or 'undefined' on '@token[Characters Journal]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key 'Exit to Characters' or 'undefined' on '@token[Exit to Characters]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key 'Storage' or 'undefined' on '@token[Storage]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key 'PC 1 Info' or 'undefined' on '@token[PC 1 Info]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key 'Otari Stat Block' or 'undefined' on '@token[Otari Stat Block]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key 'Gazette' or 'undefined' on '@token[Gazette]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key 'Support' or 'undefined' on '@token[Support]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '1. The Giant's Wheel' or 'undefined' on '@token[1. The Giant's Wheel]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '2. Loading Flume' or 'undefined' on '@token[2. Loading Flume]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '3. Menhemes Manor' or 'undefined' on '@token[3. Menhemes Manor]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '4. Wrin's Wonder's' or 'undefined' on '@token[4. Wrin's Wonder's]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '5. Gallentine Deliveries' or 'undefined' on '@token[5. Gallentine Deliveries]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '6. Blades For Glades' or 'undefined' on '@token[6. Blades For Glades]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '7. Odd Stories' or 'undefined' on '@token[7. Odd Stories]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '8. Otari Garrison' or 'undefined' on '@token[8. Otari Garrison]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '9. Farmer's Guild' or 'undefined' on '@token[9. Farmer's Guild]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '10. Crow's Casks' or 'undefined' on '@token[10. Crow's Casks]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '11. Crook's Nook' or 'undefined' on '@token[11. Crook's Nook]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '12. Otari Market' or 'undefined' on '@token[12. Otari Market]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '13. Otari Fishery' or 'undefined' on '@token[13. Otari Fishery]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '14. Thirsty Alpaca Ruins' or 'undefined' on '@token[14. Thirsty Alpaca Ruins]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '15. Inkleholtz Manor' or 'undefined' on '@token[15. Inkleholtz Manor]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '16. Chertel Manor' or 'undefined' on '@token[16. Chertel Manor]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '17. The Rowdy Rockfish' or 'undefined' on '@token[17. The Rowdy Rockfish]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '18. Dawnflower Library' or 'undefined' on '@token[18. Dawnflower Library]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '19. Stone Ring Pond' or 'undefined' on '@token[19. Stone Ring Pond]' trigger.js:7:11
trigger-happy | Can't retrieve the config with entity 'token' and key '20. Otari Graveyard' or 'undefined' on '@token[20. Otari Graveyard]' trigger.js:7:11

@p4535992
Copy link
Collaborator

Sorry they are in red color or yellow color ? If they are yellow is normal is mean the triggers are not present on the current scene.
Details on this paragraph : https://github.com/League-of-Foundry-Developers/fvtt-module-trigger-happy#details
I'm still looking.

@himmelweiss
Copy link

himmelweiss commented Jan 19, 2022

So i was just playing around with a simple folder permission macro for changing permissions quickly for a few hundred journal notes within a selected folder.

Everytime the following code gets executed it triggers the yellow trigger-happy warning messages "can't retrieve the config with entity 'token' and key..." for all token triggers i have set up:
currentFolder.content.forEach(async note => { const newPerms = duplicate(doc.data.permission); newPerms.default = Number(desiredPermission); await doc.update({ permission: newPerms }); });

I get thousands and thousands of theese yellow trigger-happy messages and it extremly lags out the entire foundry app.
So how comes i trigger something on trigger-happy with the macro above?

Yes, if i switch to the scene where theese triggers are present, the warning messages don't show up after executing said macro above, but trigger-happy is still doing something in the background and it lags out the entire foundry app, even without the warning messages.

@p4535992
Copy link
Collaborator

p4535992 commented Jan 24, 2022

hi @himmelweiss try this beta and let me know if the problem is solved:
https://github.com/p4535992/fvtt-module-trigger-happy/releases/download/v0.8.35/module.json.

The problem is not "fully" solved, but now the refreshing is limited to the update/delete/create journals in the 'Trigger Happy' folder. Should be enough for this use case.

P.S. next time open a new issue .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants