Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Zip Path not defined error #733

Closed
1 task done
manu2551988 opened this issue Nov 2, 2023 · 0 comments
Closed
1 task done

[Bug] Zip Path not defined error #733

manu2551988 opened this issue Nov 2, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@manu2551988
Copy link

Steps to reproduce/复现步骤

  1. Download latest repository
  2. Go to path ./scripts
  3. Open PowerShell as admin
  4. Run command cd filepath
  5. Run command wsl
  6. Run command ./run.sh
  7. Navigate through instruction onscreen
  8. Select Insider Fast -- Make sure latest build i.e. WSA 2310 zip with file name as wsa-WIF.zip pasted in download folder
  9. Wait for installation steps to complete

Expected behaviour/预期行为

WSA 2310 folder should be extracted into output folder

Actual behaviour/实际行为

Installation throws error

Status Legend: (OK):download completed. Extract WSA Traceback (most recent call last): File "/mnt/c/MagiskOnWSALocal/scripts/extractWSA.py", line 109, in <module> with zipfile.ZipFile(zip_path) as zip: NameError: name 'zip_path' is not defined. Did you mean: 'zip_name'? ERROR: Unzip WSA failed, is the download incomplete? Build: an error has occurred, exit

MagiskOnWSALocal commit full SHA/MagiskOnWSALocal 提交的完整哈希

d44a77b

Linux distribution info/Linux 发行版信息

Ubuntu 22.04.3 LTS

Windows version/Windows 版本

22623.885

Build Parameters/构建参数

COMMAND_LINE=--arch x64 --release-type WIF --root-sol magisk --gapps-brand MindTheGapps --magisk-ver stable
INFO: Architecture: x64
INFO: Release Type: WIF
INFO: Magisk Version: stable
INFO: GApps Brand: MindTheGapps
INFO: GApps Variant: pico
INFO: Root Solution: magisk
Build: RELEASE_TYPE=Insider Fast
Generate Download Links
Generating WSA download link: arch=x64 release_type=Insider Fast

Version requirement/版本要求

  • I am using latest commit of MagiskOnWSALocal/我正在使用最新 commit 的版本

Logs/日志

# Download Results:
gid   |stat|avg speed  |path/URI
======+====+===========+=======================================================
a660b5|OK  |       0B/s|../download/wsa-WIF.zip
604e41|OK  |   3.8MiB/s|../download/Microsoft.VCLibs.140.00_x64.appx
ce00fa|OK  |   9.9MiB/s|../download/magisk-stable.zip
457feb|OK  |   2.7MiB/s|../download/Microsoft.UI.Xaml.2.8_x64.appx
4a0daa|OK  |   3.4MiB/s|../download/Microsoft.VCLibs.140.00.UWPDesktop_x64.appx
65b2aa|OK  |    13MiB/s|../download/MindTheGapps-x64-13.0.zip

Status Legend:
(OK):download completed.
Extract WSA
Traceback (most recent call last):
  File "/mnt/c/MagiskOnWSALocal/scripts/extractWSA.py", line 109, in <module>
    with zipfile.ZipFile(zip_path) as zip:
NameError: name 'zip_path' is not defined. Did you mean: 'zip_name'?
ERROR: Unzip WSA failed, is the download incomplete?
Build: an error has occurred, exit
![Screenshot 2023-11-02 194131](https://github.com/LSPosed/MagiskOnWSALocal/assets/59497187/61db2949-b5b2-4885-8532-278110e41e24)
@manu2551988 manu2551988 added the bug Something isn't working label Nov 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant