Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run and upload coverage tests #25

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rusu24edward
Copy link
Contributor

Resolves #5
Resolves #14

@aperloff
Copy link
Member

@rusu24edward, there is a test failing and some conflicts. Once you fix those I will review. Thank you.

@rusu24edward
Copy link
Contributor Author

I resolved the conflict. I believe the failing test is a result of me adding the test suite to the CI, which is expected to fail until we resolve #18 and #37

@rusu24edward
Copy link
Contributor Author

Actually, the failure is this:

ERROR: usage: __main__.py [options] [file_or_dir] [file_or_dir] [...]
__main__.py: error: unrecognized arguments: -n ./tests/
  inifile: /home/runner/work/SSAPy/SSAPy/setup.cfg
  rootdir: /home/runner/work/SSAPy/SSAPy

I've run into this a few times running the test suite. Basically, in setup.cfg, there is an alias for pytest which adopts -n 8 --junitxml=pytest.xml. But pytest doesn't take an argument -n, so it fails. When I run the test suite locally, I remove setup.cfg to avoid the alias and just run pytest ./tests. Can you explain a bit what setup.cfg is for? Am I running the test suite correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Looks like CI isn't running the tests or code coverage Unit tests aren't running in CI
2 participants