Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncAPI Schema object deserializer is missing some properties #122

Closed
crudbee opened this issue Jul 31, 2023 · 2 comments · Fixed by #124
Closed

AsyncAPI Schema object deserializer is missing some properties #122

crudbee opened this issue Jul 31, 2023 · 2 comments · Fixed by #124
Labels

Comments

@crudbee
Copy link
Contributor

crudbee commented Jul 31, 2023

Describe the bug

Schema deserializer AsyncApiSchemaDeserializer.cs is missing some fixed fields compared to the AsyncAPI specification.

In particular:

patternProperties 
additionalItems 
propertyNames

Additional context

Similar PR's touching the same code #120 and #121

@crudbee crudbee added bug Something isn't working asyncapi.readers labels Jul 31, 2023
@github-actions
Copy link

Welcome to AsyncAPI.NET. Thank you for reporting your first issue. Please check out our contributors guide.

@VisualBean
Copy link
Collaborator

VisualBean commented Jul 31, 2023

additionalItems and items looks to be the same property, but according to spec 2.6 we should support both.
https://json-schema.org/understanding-json-schema/reference/array.html
https://www.asyncapi.com/docs/reference/specification/v2.6.0

It also looks like its another one of those 'bool' or 'object' types of things.

For the others as a reference for later
https://json-schema.org/understanding-json-schema/reference/object.html#pattern-properties
https://json-schema.org/understanding-json-schema/reference/object.html#property-names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants