Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krpc-ktor-server to support Multiplatform #209

Open
tristancaron opened this issue Sep 26, 2024 · 3 comments
Open

krpc-ktor-server to support Multiplatform #209

tristancaron opened this issue Sep 26, 2024 · 3 comments
Assignees
Labels
feature New feature or request

Comments

@tristancaron
Copy link

Looking at the content of this module, it does seem that it could be moved under commonMain. Its dependencies are supporting multiplatform.

https://github.com/Kotlin/kotlinx-rpc/blob/main/krpc/krpc-ktor/krpc-ktor-server/build.gradle.kts

@tristancaron tristancaron added the feature New feature or request label Sep 26, 2024
@Mr3zee
Copy link
Collaborator

Mr3zee commented Sep 26, 2024

Hi! The server module uses JVM reflection to invoke service methods, so the update is not straightforward. But we plan to do it eventually, yes

@TristanCaronUnity
Copy link

Ah missed that one. Thanks for the update.

@Zymus
Copy link

Zymus commented Oct 6, 2024

Hi! The server module uses JVM reflection to invoke service methods, so the update is not straightforward. But we plan to do it eventually, yes

Thanks for the JVM tip. I was struggling getting a MP with mingw setup, and hadn't targeted jvm in my project yet. Adding jvm and removing mingw allowed me to build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants