Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of CWallet::OrderedTxItems and keep wallet transactions in memory always ordered #579

Open
dimxy opened this issue Mar 28, 2023 · 0 comments
Open

Get rid of CWallet::OrderedTxItems and keep wallet transactions in memory always ordered #579

dimxy opened this issue Mar 28, 2023 · 0 comments

Comments

@dimxy
Copy link
Collaborator

dimxy commented Mar 28, 2023

Currently transactions in wallet's memory are ordered on purpose in OrderedTxItems. Also each in call to OrderedTxItems a walletdb is created which may take thousands of milliseconds. This especially affects importprivkey rpc.
The fix should remove OrderedTxItems() method and always keep transactions ordered.
When implementing avoid creating CWalletDB inside loops.

See also zcash@31d49b0
who-biz pushed a commit to who-biz/komodo that referenced this issue Jul 29, 2024
@Asherda
Merge pull request KomodoPlatform#579 from Asherda/release-v1.2.3-3
ccc1de0 
Release v1.2.3-3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dimxy