Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComfyUI support! #1

Open
toyxyz opened this issue Mar 23, 2024 · 8 comments
Open

ComfyUI support! #1

toyxyz opened this issue Mar 23, 2024 · 8 comments

Comments

@toyxyz
Copy link

toyxyz commented Mar 23, 2024

Thank you for your wonderful work!

I have made some modifications to support comfyui.

Please check and tell me if you like it!

https://github.com/toyxyz/a1111-sd-webui-dtg_comfyui

image

@yoinked-h
Copy link

yoinked-h commented Mar 24, 2024

i made another version that uses gradio_client ( #2 )

@KohakuBlueleaf
Copy link
Owner

@toyxyz I think this is good but I have some small questions (may related to how comfyui load the custom nodes so if it some of the question/problem is unsovlable, ignore them)

  1. Is the init.py in root path avoidable? Like add "os.path.basedir(file)" to sys.path temporarily.
  2. The parse_attention code is from a1111, which is under AGPL3. I'm considering if ComfyUI have similar code for parsing emphasis for prompts and can allow you to import. (So you can avoid some license issue)

@toyxyz
Copy link
Author

toyxyz commented Mar 26, 2024

@toyxyz I think this is good but I have some small questions (may related to how comfyui load the custom nodes so if it some of the question/problem is unsovlable, ignore them)

  1. Is the init.py in root path avoidable? Like add "os.path.basedir(file)" to sys.path temporarily.
  2. The parse_attention code is from a1111, which is under AGPL3. I'm considering if ComfyUI have similar code for parsing emphasis for prompts and can allow you to import. (So you can avoid some license issue)

Thank you! but my programming skills are not very good, so I don't think I can give you a definitive answer.

To the best of my knowledge, the answer is this.

  1. custom nodes won't work without init.py.
    Here's another extension that supports both webui and ComfyUI.
    https://github.com/mcmonkeyprojects/sd-dynamic-thresholding

  2. ComfyUI has an parsing emphasis code. I don't know how to use it though. As I understand it, the emphasis of webui and comfyui is calculated a bit differently.
    There is a custom node for generating the same image as webui in comfyui.
    https://github.com/shiimizu/ComfyUI_smZNodes

@KohakuBlueleaf
Copy link
Owner

@toyxyz I have updated lot of logic inside my code and now I seperate the kgen into standalone projects

You may want to check it!
https://github.com/KohakuBlueleaf/KGen

@XJF2332
Copy link

XJF2332 commented Aug 13, 2024

Thank you for your wonderful work!

I have made some modifications to support comfyui.

Please check and tell me if you like it!

https://github.com/toyxyz/a1111-sd-webui-dtg_comfyui

image

I encountered an issue while installing your plugin.
Your install.py requires launch, after attempting to install launch, pip says launch requires flowdas-meta.
I tried pip install flowdas-meta, but pip errored out, saying it couldn't find a suitable version.
I found that flowdas-meta has been removed from PyPI, and I couldn't find a tar.gz file for manual installation.
Can you replace launch with other modules or provide a tag.gz file for flowdas-meta?
Or, is there any other solution to this problem?
Thank you.

@KohakuBlueleaf
Copy link
Owner

Thank you for your wonderful work!
I have made some modifications to support comfyui.
Please check and tell me if you like it!
https://github.com/toyxyz/a1111-sd-webui-dtg_comfyui
image

I encountered an issue while installing your plugin. Your install.py requires launch, after attempting to install launch, pip says launch requires flowdas-meta. I tried pip install flowdas-meta, but pip errored out, saying it couldn't find a suitable version. I found that flowdas-meta has been removed from PyPI, and I couldn't find a tar.gz file for manual installation. Can you replace launch with other modules or provide a tag.gz file for flowdas-meta? Or, is there any other solution to this problem? Thank you.

launch.py is for sd-webui to install essential dependencies.
if you are using comfy, you should ignore that file.

@XJF2332
Copy link

XJF2332 commented Aug 13, 2024

Thank you for your wonderful work!
I have made some modifications to support comfyui.
Please check and tell me if you like it!
https://github.com/toyxyz/a1111-sd-webui-dtg_comfyui
image

I encountered an issue while installing your plugin. Your install.py requires launch, after attempting to install launch, pip says launch requires flowdas-meta. I tried pip install flowdas-meta, but pip errored out, saying it couldn't find a suitable version. I found that flowdas-meta has been removed from PyPI, and I couldn't find a tar.gz file for manual installation. Can you replace launch with other modules or provide a tag.gz file for flowdas-meta? Or, is there any other solution to this problem? Thank you.

launch.py is for sd-webui to install essential dependencies. if you are using comfy, you should ignore that file.

thank you for solving that!
however, I ran into another warning saying that Llama-cpp-python not found, using transformers to load model, but I can find llama-cpp-python using pip list.
do you know the reason why?
image

@XJF2332
Copy link

XJF2332 commented Aug 13, 2024

Thank you for your wonderful work!
I have made some modifications to support comfyui.
Please check and tell me if you like it!
https://github.com/toyxyz/a1111-sd-webui-dtg_comfyui
image

I encountered an issue while installing your plugin. Your install.py requires launch, after attempting to install launch, pip says launch requires flowdas-meta. I tried pip install flowdas-meta, but pip errored out, saying it couldn't find a suitable version. I found that flowdas-meta has been removed from PyPI, and I couldn't find a tar.gz file for manual installation. Can you replace launch with other modules or provide a tag.gz file for flowdas-meta? Or, is there any other solution to this problem? Thank you.

launch.py is for sd-webui to install essential dependencies. if you are using comfy, you should ignore that file.

btw, although the tab says C:\Windows\system32\cmd.exe, it's actually running at:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants