Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chamfer distance question #66

Open
tomas-aftalion opened this issue Jul 7, 2023 · 2 comments
Open

Chamfer distance question #66

tomas-aftalion opened this issue Jul 7, 2023 · 2 comments

Comments

@tomas-aftalion
Copy link

Hi, had a question regarding Chamfer distance. What are the benefits of using the compiled cuda extension vs writing a simple pytorch version of it? Is there something fundamental that simply can't be implemented in pytorch?

@auniquesun
Copy link

auniquesun commented Aug 23, 2023

@tomas-aftalion In fact, pytorch3d has implemented chamfer distance. I think the author just borrow the code from other sources, which are implemented with cuda. I think there is no big difference.

My goal is to re-implement this repo with pure python an pytorch, without introducing c/c++ extensions. The extenstions seems not concise and are easy to produce problems when compiling.

Stay tuned!

@yuxumin
Copy link
Collaborator

yuxumin commented Aug 23, 2023

Hey, thanks a lot, guys! We implemented it in CUDA for convenience, which we directly borrowed from another repository. The CUDA-based chamfer has been widely used in some 3D task repositories, which allows for faster calculation speed.

Implementing it in pure PyTorch should save a lot of time on compiling. I really appreciate your attention and effort in this matter. Please feel free to let me know if you have any further questions or need any assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants