Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "New package: FortranNamelistParser v0.1.0" #117175

Conversation

ericphanson
Copy link
Member

@ericphanson ericphanson commented Oct 13, 2024

Reverts #116786 cc @anchal-physics

context: https://discourse.julialang.org/t/remove-package-from-general-registry/71668/5

rationale:

  • in general we don't remove packages from General, but we have on occasion when very soon after registering and we think no one else is using the package yet, and the author made some mistake that is very difficult or labor intensive to fix otherwise
  • I don’t see any open-source usages of it on github outside of ProjectTorreyPines org which has that registry they mention and @anchal-physics, the package owner, and what looks like a mirror of general (https://github.com/search?q=FortranNamelistParser&type=code&p=1), but of course there’s code other than open-source code on github.
  • I would vote for reverting today; I don’t think it needs to be precedent but rather, this is handled on a case by case basis and in this case it seems like it won’t affect anyone outside this group, for whom reverting will help a lot. I think maintaining reproducibility and not breaking code is essential but it seems like that won’t happen here, and combining registries can be messy and someone made a mistake that we can help fix.
  • waiting longer just increases the odds someone else will use it, so we should revert it quickly or not at all

@Keno
Copy link
Contributor

Keno commented Oct 13, 2024

Acceptable to me for reasons provided.

@ericphanson ericphanson merged commit 130da7d into master Oct 13, 2024
9 checks passed
@ericphanson ericphanson deleted the revert-116786-registrator-fortrannamelistparser-8fb689aa-v0.1.0-6eac266378 branch October 13, 2024 00:49
@anchal-physics
Copy link

anchal-physics commented Oct 14, 2024

Thanks a lot for quick resolution of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants