-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing the TableTransforms.jl transformer interface in a different package #175
Comments
Hi @EssamWisam , thank you for opening the issue. You mean that you would like to see a dev guide in our docs? In general, all you need to do to adhere to the interface here is to implement a subset of
|
I think that would be nice in general for people wanting to implement custom transforms that adhere with this nice API. The option I considered before this one was MLJ and it was in the docs, that's why I thought I would find a similar one here as an initial impression. Thank you so much for the helpful answer. |
Thank you @EssamWisam. If you can contribute this section based on your experience implementing the interface, that would be super helpful. GitHub allows you to edit the repository without headache, you can press Do you think you can tackle this? Happy to help. |
@juliohm I will see if I could do that after I finish. I have a quick question, what advantage do I get by implementing subsets of the functions included in |
In theory you only need to depend on TransformsBase.jl to get full
integration.
Em dom., 30 de jul. de 2023 11:03, Essam ***@***.***>
escreveu:
… @juliohm <https://github.com/juliohm> I will see if I could do that after
I finish. I have a quick question, what advantage do I get by implementing
subsets of the functions included inTableTransforms.jl\transforms.jl
(i.e., indirectly implementing those in TransformsBase.jl) over only
using TransformsBase.jl and implementing the required functions? The end
goal is to perhaps ensure composability with other transforms in the
package when TableTransforms.jl is used.
—
Reply to this email directly, view it on GitHub
<#175 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZQW3IHDZAFDHFHEXI76FLXSZSRRANCNFSM6AAAAAA24MKKKE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@EssamWisam did you have a chance to implement the interface? Can you help writing a section in the docs? |
@juliohm I believe yes, using |
I'm working on a small package for oversampling input tables. I thought it would be nice if I make it possible to use the methods in the package using a similar API to the one here but I couldn't find the relevant section to help me do that in the docs.
The text was updated successfully, but these errors were encountered: