Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rounding mode in construction of BigFloat from pi #55911

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix rounding mode in construction of BigFloat from pi #55911

wants to merge 1 commit into from
+24 −1

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented Sep 27, 2024

The default argument of the method was outdated, reading the global default rounding directly, bypassing the ScopedValue stuff.

@nsajko
fix rounding mode in construction of BigFloat from pi
6084df3 
The default argument of the method was outdated, reading the global
default rounding directly, bypassing the `ScopedValue` stuff.
@nsajko nsajko added kind:bugfix This change fixes an existing bug domain:bignums BigInt and BigFloat labels Sep 27, 2024
@nsajko
Copy link
Contributor Author

nsajko commented Sep 27, 2024

This applies to the Irrational values defined as MPFR constants: π, γ, catalan.

@nsajko nsajko added backport 1.11 Change should be backported to release-1.11 and removed backport 1.11 Change should be backported to release-1.11 labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
domain:bignums BigInt and BigFloat kind:bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nsajko