Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try adding more unwind info to builds fix profiling #55904

Closed

Conversation

IanButterworth
Copy link
Sponsor Member

Mainly opening as a place to collect attempts to improve profiling sampling (on MacOS, but maybe more generally)

I have no idea how repeatable these are but as an example, profiling some printing stuff and showing with ProfileView.view(C=true)

master

Screenshot 2024-09-26 at 10 52 58 PM

this PR

with

USE_BINARYBUILDER_LIBUNWIND := 0
USE_BINARYBUILDER_OPENBLAS := 0
USE_BINARYBUILDER_OBJCONV := 0

Screenshot 2024-09-27 at 1 57 59 PM

@IanButterworth
Copy link
Sponsor Member Author

Also, with changing these options

LLVMUNWIND_OPTS := $(CMAKE_COMMON) \

to

	-DCMAKE_BUILD_TYPE="Debug" \
	-DLIBUNWIND_ENABLE_PEDANTIC=ON \
	-DLIBUNWIND_ENABLE_ASSERTIONS=ON \

I get

julia> @profile peakflops()
libunwind: malformed __unwind_info at 0x198E98648 bad second level page
libunwind: malformed __unwind_info at 0x10137BDF0 bad second level page
libunwind: malformed __unwind_info at 0x10137BDF0 bad second level page
libunwind: malformed __unwind_info at 0x100F30764 bad second level page
libunwind: malformed __unwind_info at 0x107A23368 bad second level page
libunwind: malformed __unwind_info at 0x107A23368 bad second level page
libunwind: malformed __unwind_info at 0x198E98648 bad second level page
1.435980408806884e11

@IanButterworth IanButterworth deleted the ib/more_unwind_info branch September 28, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant