Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In ntuple, respect the type of the count argument #55825

Closed
wants to merge 1 commit into from
Closed

In ntuple, respect the type of the count argument #55825

wants to merge 1 commit into from

Conversation

mhauru
Copy link
Contributor

@mhauru mhauru commented Sep 20, 2024

Resolves #55790

@LilithHafner LilithHafner added the kind:bugfix This change fixes an existing bug label Sep 20, 2024
@mhauru mhauru mentioned this pull request Sep 20, 2024
Open
@LilithHafner
Copy link
Member

Thanks for the PR!

@JeffBezanson
Copy link
Sponsor Member

As observed here: #55790 (comment) this was kind of supposed to be an index so the type can just be Int, but this change might make sense.

@JeffBezanson JeffBezanson added the status:triage This should be discussed on a triage call label Sep 20, 2024
@mastoffel mastoffel mentioned this pull request Sep 23, 2024
Closed
6 tasks
@mhauru
Copy link
Contributor Author

mhauru commented Sep 26, 2024

Triage in #55790 concluded that we should go with rather always returning Ints. Closing.

@mhauru mhauru closed this Sep 26, 2024
@LilithHafner LilithHafner removed the status:triage This should be discussed on a triage call label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind:bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ntuple eltype depends on tuple length for UInt64
3 participants
@mhauru @LilithHafner @JeffBezanson