Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional parameters to ZstdCompressor #73

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mkitti
Copy link
Member

@mkitti mkitti commented Sep 16, 2024

This draft pull request adds additional parameters for the compressor.
The implementation uses a Dict{LibZstd.ZSTD_cParameter, Cint} to store the parameters.
The properties are the overloaded to reflect the parameters.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 16 lines in your changes missing coverage. Please review.

Project coverage is 61.42%. Comparing base (e7edfed) to head (5c16f36).

Files with missing lines Patch % Lines
src/compression.jl 58.06% 13 Missing ⚠️
src/libzstd.jl 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   61.55%   61.42%   -0.14%     
==========================================
  Files           5        5              
  Lines         372      407      +35     
==========================================
+ Hits          229      250      +21     
- Misses        143      157      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkitti
Copy link
Member Author

mkitti commented Sep 16, 2024

This will have to be reworked if #71 gets merged. I'm not sure about the status of that pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant