Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ZstdError error type. Test known, stable error codes. #54

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mkitti
Copy link
Member

@mkitti mkitti commented May 29, 2024

Create a ZstdError error type.

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 37.52%. Comparing base (89cd7ed) to head (7d8e64c).

Files Patch % Lines
src/compression.jl 0.00% 4 Missing ⚠️
src/decompression.jl 0.00% 4 Missing ⚠️
src/libzstd.jl 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   36.96%   37.52%   +0.55%     
==========================================
  Files           5        5              
  Lines         560      565       +5     
==========================================
+ Hits          207      212       +5     
  Misses        353      353              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkitti
Copy link
Member Author

mkitti commented Jun 2, 2024

The main thing I am waiting for is to create test cases by intentionally creating error situations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant