Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair{0} #412

Closed
wants to merge 4 commits into from
Closed

Repair{0} #412

wants to merge 4 commits into from

Conversation

stla
Copy link
Contributor

@stla stla commented May 4, 2023

As discussed in #354

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #412 (991d884) into master (e724740) will increase coverage by 0.14%.
The diff coverage is 96.87%.

❗ Current head 991d884 differs from pull request most recent head 4d87fe0. Consider uploading reports for the commit 4d87fe0 to get more accurate results

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
+ Coverage   93.41%   93.56%   +0.14%     
==========================================
  Files         120      120              
  Lines        3525     3557      +32     
==========================================
+ Hits         3293     3328      +35     
+ Misses        232      229       -3     
Impacted Files Coverage Δ
src/transforms/repair.jl 98.14% <96.87%> (-1.86%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@juliohm juliohm changed the title Don't know what mess I did ! Repair{0} May 4, 2023
@juliohm
Copy link
Member

juliohm commented May 4, 2023

@stla I've updated the PR, cleaning the code as much as possible. Can you please reintroduce the part where the unique faces are computed using the new version?

@juliohm
Copy link
Member

juliohm commented May 5, 2023

@stla to avoid issues it Git rebase again, you can simply press . here on GitHub and it will open the files in the PR for further edition. You can then save the file and commit as if you were working locally.

@juliohm
Copy link
Member

juliohm commented May 14, 2023

@stla did you have a chance to take a look into this?

@juliohm
Copy link
Member

juliohm commented Jun 6, 2023

Closing the PR as inactive.

@juliohm juliohm closed this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants