Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization of Line #534

Open
Antoinemarteau opened this issue May 21, 2023 · 4 comments
Open

Visualization of Line #534

Antoinemarteau opened this issue May 21, 2023 · 4 comments
Labels
feature help wanted Extra attention is needed viz Issue with visualization recipes

Comments

@Antoinemarteau
Copy link

Small bug : seems the infinite long line is not possible to discretize ?

using Meshes, MeshViz
using CairoMakie: activate!; activate!()
ln = Line(Point(1,1,1), Point(0,0,0))
viz(ln)

yields StackOverflowError

Stacktrace:
[1] simplexify(geometry::Line{3, Float64})
@ Meshes ~/.julia/packages/Meshes/1Iszy/src/discretization.jl:135
[2] discretize(geometry::Line{3, Float64})
@ Meshes ~/.julia/packages/Meshes/1Iszy/src/discretization.jl:103
--- the last 2 lines are repeated 39990 more times ---
[79983] simplexify(geometry::Line{3, Float64})
@ Meshes ~/.julia/packages/Meshes/1Iszy/src/discretization.jl:135

Got the same with GLMakie backend.

@juliohm juliohm added bug Something isn't working help wanted Extra attention is needed labels May 22, 2023
@juliohm
Copy link
Member

juliohm commented May 22, 2023

We do not know how to plot infinite geometries like lines yet. Any help is appreciated on a good approach. If Makie.jl has a trick to represent infinite lines and planes, please let us know and we can add the recipe here.

@Antoinemarteau
Copy link
Author

I have no idea of what is possible in Makie (I just wanted to report the bug), would you like that I try to do a PR to catch the viz calls on Line and throw a TypeError ?

@juliohm
Copy link
Member

juliohm commented May 24, 2023 via email

@juliohm
Copy link
Member

juliohm commented Jun 14, 2023

@juliohm juliohm transferred this issue from JuliaGeometry/MeshViz.jl Jul 27, 2023
@juliohm juliohm added the viz Issue with visualization recipes label Jul 27, 2023
@juliohm juliohm changed the title StackOverflow on Line vizualization Visualization of infinite geometries Nov 29, 2023
@juliohm juliohm added feature and removed bug Something isn't working labels Nov 29, 2023
@juliohm juliohm changed the title Visualization of infinite geometries Visualization of Line Jan 26, 2024
@juliohm juliohm changed the title Visualization of Line Visualization of Line Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature help wanted Extra attention is needed viz Issue with visualization recipes
Projects
None yet
Development

No branches or pull requests

2 participants