From fdeda3d533df40a3c5370f7e4e6dc2cf239499b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BAlio=20Hoffimann?= Date: Fri, 18 Oct 2024 10:06:34 -0300 Subject: [PATCH] Improve accumulation for CarleEstimator --- src/empirical/algorithms.jl | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/empirical/algorithms.jl b/src/empirical/algorithms.jl index 417dc64..4924169 100644 --- a/src/empirical/algorithms.jl +++ b/src/empirical/algorithms.jl @@ -179,12 +179,10 @@ function accumulate(data, pairs, estimator::CarleEstimator, algo::AccumAlgo) # evaluate function estimator v = formula(estimator, z₁[i], z₁[j], z₂[i], z₂[j]) - # accumulate if value is valid - if all(!ismissing, v) - ns[lag] += 1 - Σx[lag] += h - Σy[lag] += v - end + # accumulate because value is always valid + ns[lag] += 1 + Σx[lag] += h + Σy[lag] += v end end end