Allow priorities to be Floats #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended the store and container objects so that priorities are not restricted to being integers. This is a more general expression of priority which may make it easier at some point to use rank functions (JuliaDynamics#75). This also avoids having to normalize (and sometimes scaling) priorities so that they are integer in queueing systems.
|
@BenLauwens can you review this PR? Thanks |
|
Ping @BenLauwens |
|
@hdavid16 , could you consider resolving the conflicts so we can try to merge this? |
|
Yes. Will do |
|
With the migration to JuliaDynamics, there are too many conflicts, despite it being a simple PR. I'll just open a new PR and add the 16 changes where priority is changed from |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the store and container objects so that priorities are not restricted to being integers.
This is a more general expression of priority which may make it easier at some point to use rank functions (#75).
This also avoids having to normalize (and sometimes scaling) priorities so that they are integer in queueing systems.