Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict the signature types of method with the recurse argument #645

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

aviatesk
Copy link
Member

These routines may be overloaded by the new recurse type, and in such cases, it is safer to restrict the method signature as much as possible (since the overloads may use @invoke to dispatch to the original method to reuse the original implementation).

These routines may be overloaded by the new `recurse` type, and in such
cases, it is safer to restrict the method signature as much as possible
(since the overloads may use `@invoke` to dispatch to the original
method to reuse the original implementation).
@aviatesk aviatesk force-pushed the avi/restrict-recurse-methodsigs branch from 4cdfcc8 to 092898b Compare September 10, 2024 14:18
Copy link
Collaborator

@simeonschaub simeonschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable

@aviatesk aviatesk merged commit 3dce7bf into master Sep 10, 2024
8 of 10 checks passed
@aviatesk aviatesk deleted the avi/restrict-recurse-methodsigs branch September 10, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants