Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run tests with both backends #262

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

run tests with both backends #262

wants to merge 12 commits into from

Conversation

ericphanson
Copy link
Member

closes #261

@ericphanson
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 19, 2022
@bors
Try #262:
1422330
github-actions[bot]
github-actions bot reviewed Jul 19, 2022
View reviewed changes
test/runtests.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
@ericphanson @github-actions
Update test/runtests.jl
0a65904 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jul 19, 2022

try

Build failed:

@ericphanson
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 19, 2022
@bors
Try #262:
d35f531
@bors
Copy link
Contributor

bors bot commented Jul 19, 2022

try

Build failed:

@ericphanson
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 19, 2022
@bors
Try #262:
4186463
@bors
Copy link
Contributor

bors bot commented Jul 19, 2022

try

Build failed:

@ericphanson
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 19, 2022
@bors
Try #262:
7200c6a
@ericphanson ericphanson mentioned this pull request Jul 19, 2022
Merged
@bors
Copy link
Contributor

bors bot commented Jul 19, 2022

try

Build failed:

@ericphanson ericphanson mentioned this pull request Jul 19, 2022
Open
@ericphanson
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 19, 2022
@bors
Try #262:
b008b5c
github-actions[bot]
github-actions bot reviewed Jul 19, 2022
View reviewed changes
test/s3path.jl Outdated Show resolved Hide resolved
ericphanson and others added 2 commits July 19, 2022 14:49
@ericphanson
add newlines, fix spacing
0438447
@ericphanson @github-actions
Update test/s3path.jl
e1eb51c 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jul 19, 2022

try

Build failed:

github-actions[bot]
github-actions bot reviewed Jul 19, 2022
View reviewed changes
test/s3path.jl Outdated Show resolved Hide resolved
@ericphanson
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 19, 2022
@bors
Try #262:
d6d26de
@bors
Copy link
Contributor

bors bot commented Jul 19, 2022

try

Build succeeded:

@ararslan
Copy link
Member

Bump. Is this still relevant?

mattBrzezinski
mattBrzezinski approved these changes Oct 11, 2022
View reviewed changes
test/runtests.jl
awss3_tests(aws)
s3path_tests(aws)

prev_backend = AWS.DEFAULT_BACKEND[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep track of the previous backend and reset it? We don't bother w/ AWS.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@mattBrzezinski mattBrzezinski mattBrzezinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run tests with both AWS backends
3 participants
@ericphanson @ararslan @mattBrzezinski