Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use REPL doctest for center/centered #254

Merged
merged 2 commits into from
Aug 19, 2021
Merged

use REPL doctest for center/centered #254

merged 2 commits into from
Aug 19, 2021

Conversation

johnnychen94
Copy link
Member

Resolves #253 (comment)

Although the script mode doctest is shorter, it somehow doesn't look very nice. This PR switches back to the REPL mode doctest for center/centered.

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #254 (ca63d80) into master (6cbc7f1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   95.41%   95.41%           
=======================================
  Files           5        5           
  Lines         436      436           
=======================================
  Hits          416      416           
  Misses         20       20           
Impacted Files Coverage Δ
src/OffsetArrays.jl 98.29% <ø> (ø)
src/axes.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cbc7f1...ca63d80. Read the comment docs.

@jishnub
Copy link
Member

jishnub commented Aug 18, 2021

Could you also give an example of what cp is supposed to do in centered? Otherwise looks good to me.

@johnnychen94
Copy link
Member Author

Regardless of the implementation simplicity, I have to admit this became a bad design practice. See #256 for more comments.

It's unlikely to correct it without breaking change, so for now, I'll just assume the current behavior is wanted and add some docstring to it.

@johnnychen94 johnnychen94 merged commit f3fad96 into master Aug 19, 2021
@johnnychen94 johnnychen94 deleted the jc/center_docs branch August 19, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants