Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pychromecast is broken on Windows #208

Closed
JohnStrunk opened this issue Jan 5, 2023 · 2 comments · Fixed by #239
Closed

Pychromecast is broken on Windows #208

JohnStrunk opened this issue Jan 5, 2023 · 2 comments · Fixed by #239
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@JohnStrunk
Copy link
Owner

Versions of pychromecast 13.0.2 and later don't work on windows due to the lack of support for poll()

Potential fix:
@JohnStrunk JohnStrunk added bug Something isn't working dependencies Pull requests that update a dependency file labels Jan 5, 2023
@JohnStrunk JohnStrunk mentioned this issue Jan 5, 2023
Merged
@strunker
Copy link

strunker commented Jan 7, 2023 •
edited
Loading

Just so you know we fixed this issue. Sadly, the fixed code is currently sitting in a pull request, and has been for the past two weeks. We are waiting on the project owner to approve the PR.

@JohnStrunk
Copy link
Owner Author

@strunker When I noticed the problem, I was very happy to see that you already had a PR for it. Thanks!

@JohnStrunk JohnStrunk mentioned this issue Mar 21, 2023
Merged
@mergify mergify bot closed this as completed in #239 Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update tools JohnStrunk/wahoo-results
2 participants
@strunker @JohnStrunk