Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Increase the UDP timeout #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Increase the UDP timeout #110

wants to merge 1 commit into from

Conversation

fortuna
Copy link
Contributor

@fortuna fortuna commented Feb 1, 2023

This may address some issues with UDP.

Fixes #109.

@fortuna
Increase the UDP timeout
aa1001f 
This may address some issues with UDP.
Fixes #109.
@fortuna fortuna requested a review from jyyi1 February 1, 2023 01:21
@fortuna fortuna requested a review from a team as a code owner February 1, 2023 01:21
@fortuna fortuna mentioned this pull request Feb 1, 2023
Closed
@bemasc
Copy link
Contributor

bemasc commented Feb 1, 2023

Note that this is the upstream read, so network misbehavior has no effect. Any app that retries its UDP packet at least once every 30 seconds will keep the NAT entry open.

jyyi1
jyyi1 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, is 5min too long for the user to wait for the connection? Suppose the server crashed between CheckUDPConnectivityWithDNS and registerConnectionHandlers, the user might need to wait for at most 5 mins to be successfully connect/disconnect.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jyyi1 jyyi1 jyyi1 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove or extend UDP listening timeout
3 participants
@fortuna @bemasc @jyyi1