Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cocoapods #1

Open
clayellis opened this issue Apr 23, 2019 · 8 comments
Open

Cocoapods #1

clayellis opened this issue Apr 23, 2019 · 8 comments

Comments

@clayellis
Copy link

Hey @JanC 👋

Thanks for creating this wrapper! If I were to submit a PR adding support for Cocoapods, would you be open to accepting that?

@JanC
Copy link
Owner

JanC commented Apr 24, 2019

Hi Clay
of course, I’d be happy to :)

If you are interested in using TSKit, I will go through the readme and update it. I believe it’s a bit outdated

cheers

@clayellis
Copy link
Author

Thanks! Yeah I'd appreciate that 👍 I'm working through adding Cocoapods support right now — I've hit a few snags with getting libts3client.a to be included in the pods sources. Any insight you might have about that would be appreciated. I'll keep you posted on progress.

@JanC
Copy link
Owner

JanC commented Apr 24, 2019

Have you tried the vendored_libraries in the .podspec ?

@clayellis
Copy link
Author

About to try that, thanks 👍

@clayellis
Copy link
Author

@JanC take a look at my fork when you get a chance? I'm still getting a build error from xcodebuild when running pod lib lint

- NOTE  | [iOS] xcodebuild:  /Users/clay/Documents/Work/OpenSource/TSKit/TSKit/Public/TSHelper.m:10:9: fatal error: 'teamspeak/clientlib.h' file not found

even though TSKit/include/teamspeak/clientlib.h is captured by:

spec.source_files         = ..., "TSKit/include/**/*.h"

@JanC
Copy link
Owner

JanC commented Apr 24, 2019

I'll have a look at it

@clayellis
Copy link
Author

Any luck? I think what’s happening (based on documentation for header_dir and header_mappings_dir) is that the headers are getting flattened into a single directory and breaking the includes (since all of the errors that xcodebuild are throwing are about nested header imports (<teamspeak/clientlib.h>) but I’ve tried every combination that makes sense on those two build settings with no luck. I’ve even flattened the entire project so that all of the files live at the same level and it makes it much further in the build process but with about 20 more errors. That may be progress…? I'm not super familiar with Cocoapods, I'm more of a Carthage guy by experience.

@JanC
Copy link
Owner

JanC commented Apr 25, 2019

Same for me. I spend a couple of hours trying without any luck. There is also the spec.preserve_paths that is suppose to keep any folder structure as it is but I does not seem to help

I opened this SO question
https://stackoverflow.com/questions/55842342/cocoapods-podspec-cannot-find-headers

I could swear that I already shipped a podspec that uses a static c library before without too much issues :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants