Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vader for temperature linear variable change #946

Open
5 tasks
travissluka opened this issue Aug 18, 2023 · 2 comments · May be fixed by #964
Open
5 tasks

Use vader for temperature linear variable change #946

travissluka opened this issue Aug 18, 2023 · 2 comments · May be fixed by #964
Assignees
@travissluka @Dooruk
Labels
SOCA Sea-ice, Ocean, and Coupled Assimilation
Milestone
Technical Debt Sp...

Comments

@travissluka
Copy link
Collaborator

travissluka commented Aug 18, 2023 •
edited
Loading

Description

similar to #924, except for the linear variable changes

  • Modify the SOCA LinearVariableChange class to use VADER
  • Modify the insitu T/S yaml in (e.g. 3dvar ctest) to use the generic VertInterp, and therefore use VADER
  • make sure everything is working as expected!
  • Remove all usage of InsituTemperature observation operator in the ctests, and consider it deprecated
  • open issues in skylab/soca-science to do the same yaml changes

Dependencies:
@travissluka travissluka added the SOCA Sea-ice, Ocean, and Coupled Assimilation label Aug 18, 2023
@travissluka
Copy link
Collaborator Author

Fyi @Dooruk, I should have a branch in soca with the changes needed "ready" to test with your Vader branch

@travissluka
Copy link
Collaborator Author

Fyi @Dooruk, I should have a branch in soca with the changes needed "ready" to test with your Vader branch

Tomorrow... I left out the word "tomorrow"

@travissluka travissluka linked a pull request Oct 3, 2023 that will close this issue
Draft
@symoore90 symoore90 added this to the Technical Debt Sprint milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@travissluka travissluka

@Dooruk Dooruk

Labels
SOCA Sea-ice, Ocean, and Coupled Assimilation
Projects
None yet
Milestone
Technical Debt Sprint
Development

Successfully merging a pull request may close this issue.

Use VADER for insitu/potential TL/AD JCSDA-internal/soca
3 participants
@travissluka @Dooruk @symoore90