From 36ce32abe6dbeda19ec9e23221abace74a5201b9 Mon Sep 17 00:00:00 2001 From: Evan Greer Date: Thu, 26 Oct 2023 14:08:11 -0600 Subject: [PATCH] updates placement ids to long values --- .../iterableapi/IterableEmbeddedPlacement.kt | 2 +- .../IterableEmbeddedPlacementTest.kt | 24 +++++++++---------- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/iterableapi/src/main/java/com/iterable/iterableapi/IterableEmbeddedPlacement.kt b/iterableapi/src/main/java/com/iterable/iterableapi/IterableEmbeddedPlacement.kt index e40c023f9..0751674b7 100644 --- a/iterableapi/src/main/java/com/iterable/iterableapi/IterableEmbeddedPlacement.kt +++ b/iterableapi/src/main/java/com/iterable/iterableapi/IterableEmbeddedPlacement.kt @@ -84,7 +84,7 @@ data class IterableEmbeddedMessage ( class EmbeddedMessageMetadata( var messageId: String, - val placementId: Long = 0, + val placementId: Long, val campaignId: Int? = null, val isProof: Boolean = false ) { diff --git a/iterableapi/src/test/java/com/iterable/iterableapi/IterableEmbeddedPlacementTest.kt b/iterableapi/src/test/java/com/iterable/iterableapi/IterableEmbeddedPlacementTest.kt index cf04b0825..5e96d94bd 100644 --- a/iterableapi/src/test/java/com/iterable/iterableapi/IterableEmbeddedPlacementTest.kt +++ b/iterableapi/src/test/java/com/iterable/iterableapi/IterableEmbeddedPlacementTest.kt @@ -27,10 +27,10 @@ class IterableEmbeddedPlacementTest { // THEN we get appropriate embedded message object and associated placement id assertNotNull(placement) - assertThat(411, `is` (placement.placementId)) + assertThat(411L, `is`(placement.placementId)) assertThat("doibjo4590340oidiobnw", `is` (message.metadata.messageId)) - assertThat(411, `is` (message.metadata.placementId)) + assertThat(411L, `is` (message.metadata.placementId)) assertThat(2324,`is` (message.metadata.campaignId)) assertThat(true, `is` (message.metadata.isProof)) @@ -70,10 +70,10 @@ class IterableEmbeddedPlacementTest { // THEN we get appropriate embedded message object and associated placement id assertNotNull(placement) - assertThat(411, `is` (placement.placementId)) + assertThat(411L, `is` (placement.placementId)) assertThat("doibjo4590340oidiobnw", `is` (message.metadata.messageId)) - assertThat(411, `is` (message.metadata.placementId)) + assertThat(411L, `is` (message.metadata.placementId)) assertThat(2324,`is` (message.metadata.campaignId)) assertThat(true, `is` (message.metadata.isProof)) @@ -117,10 +117,10 @@ class IterableEmbeddedPlacementTest { // THEN we get appropriate embedded message object and associated placement id assertNotNull(placement) - assertThat(411, `is` (placement.placementId)) + assertThat(411L, `is` (placement.placementId)) assertThat("doibjo4590340oidiobnw", `is` (message.metadata.messageId)) - assertThat(411, `is` (message.metadata.placementId)) + assertThat(411L, `is` (message.metadata.placementId)) assertThat(2324,`is` (message.metadata.campaignId)) assertThat(true, `is` (message.metadata.isProof)) @@ -154,10 +154,10 @@ class IterableEmbeddedPlacementTest { // THEN we get appropriate embedded message object and associated placement id assertNotNull(placement) - assertThat(411, `is` (placement.placementId)) + assertThat(411L, `is` (placement.placementId)) assertThat("doibjo4590340oidiobnw", `is` (message.metadata.messageId)) - assertThat(411, `is` (message.metadata.placementId)) + assertThat(411L, `is` (message.metadata.placementId)) assertThat(2324,`is` (message.metadata.campaignId)) assertThat(true, `is` (message.metadata.isProof)) @@ -170,7 +170,7 @@ class IterableEmbeddedPlacementTest { fun embeddedPlacementSerialization_elementsAndCustomPayloadDefined() { val embeddedMessageMetadata = EmbeddedMessageMetadata( "doibjo4590340oidiobnw", - 411, + 411L, 2324, true ) @@ -205,7 +205,7 @@ class IterableEmbeddedPlacementTest { val embeddedMessage = IterableEmbeddedMessage(embeddedMessageMetadata, embeddedMessageElements, customPayload) - val placementId: Long = 411 + val placementId: Long = 411L val messages: List = listOf(embeddedMessage) val embeddedMessagePlacement = IterableEmbeddedPlacement(placementId, messages) @@ -229,7 +229,7 @@ class IterableEmbeddedPlacementTest { fun embeddedPlacementSerialization_noButtons_noText() { val embeddedMessageMetadata = EmbeddedMessageMetadata( "doibjo4590340oidiobnw", - 411, + 411L, 2324, true ) @@ -250,7 +250,7 @@ class IterableEmbeddedPlacementTest { val embeddedMessage = IterableEmbeddedMessage(embeddedMessageMetadata, embeddedMessageElements, customPayload) - val placementId: Long = 411 + val placementId: Long = 411L val messages: List = listOf(embeddedMessage) val embeddedMessagePlacement = IterableEmbeddedPlacement(placementId, messages)