Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Enter key reverted to not saving. #2057

Open
markwr opened this issue Sep 24, 2024 · 10 comments · May be fixed by #2058
Open

[BUG] Enter key reverted to not saving. #2057

markwr opened this issue Sep 24, 2024 · 10 comments · May be fixed by #2058
Labels
browser specific Specific to a browser (or a certain version of such) bug Something isn't working

Comments

@markwr
Copy link

markwr commented Sep 24, 2024

Expected Behavior

During "Update note", the [Enter] key saves the new/edited note and exits the update.

Actual Behavior

During "Update note", the [Enter] key exits the update without saving the new/edited note.

Steps to Reproduce the Problem

  1. Go to store.steampowered.com for a specific game.
  2. Click [Update note].
  3. Edit the note.
  4. Press the [Enter} key on keyboard.
  5. Observe that it exits from the edit box, and the note reverts back to whatever it had been before trying to edit it.

Specifications

  • Augmented Steam Version: 4.1.2
  • Browser Version: Firefox 130.0.1 (32-bit)

NOTE: See #1288 which ended up with you implementing the ability I describe above under "Expected Behavior" (around Nov 1, 2021). That ability recently became corrupted, likely during an update.

@markwr markwr added the bug Something isn't working label Sep 24, 2024
@candela97
Copy link
Collaborator

Seems like a browser difference because it works on Chrome.

@candela97 candela97 added the browser specific Specific to a browser (or a certain version of such) label Sep 25, 2024
@markwr
Copy link
Author

markwr commented Sep 26, 2024

Thanks for such a quick response. I wanted to test the fix, but Augmented Steam Version: 4.1.2 is still the newest published version at the moment. I'll need to wait for the next version before I can test the fix (unless there is a way for me to try a beta version).

@candela97
Copy link
Collaborator

You can download a build for the linked PR here https://github.com/IsThereAnyDeal/AugmentedSteam/actions/runs/11032651093

@markwr
Copy link
Author

markwr commented Sep 26, 2024

I'm a bit embarrassed to admit that I don't know how to install via that link (Build Augmented Steam (firefox) / Build firefox), ie how/where to run any of those commands. Perhaps I just need to wait for an official release. Thanks anyway.

@candela97
Copy link
Collaborator

No need to run any commands, just download a build from the Artifacts section below. To sideload on FF, enter about:debugging in the address bar and select this firefox > load temporary addon.

@candela97
Copy link
Collaborator

At the "about:debugging#/runtime/this-firefox" page I click [Load Temporary Add-on...] and it wants me to pick either a file or directory (folder). I'm hesitant to do so without one more hint from you since I don't want to screw up FF. My guess would have been to select the folder X:\firefox\ (or else one of the three files in the parent folder), but I'll wait for your response (if you have time). Thanks.

Selecting any file will do.

ps - The about:debugging page also shows my installed extensions, including "Augmented Steam". Would I first disable that official Augmented Steam version before I "sideload" (whatever that means) the beta version? And, later (when the new release version comes out, would I just uninstall the beta version and Enable the official version (and tell it to update)?

The offical one will also be disabled when you sideload a temporary one, and it will also be removed automatically after you restart FF.

@markwr
Copy link
Author

markwr commented Sep 27, 2024

Thank you. At the FF about:addons page, I first "Disabled" my release version of the FF Augmented Steam extension (maybe an unnecessary step) . Then I "sideloaded" the beta version. I notice that about:addons now shows Augmented Steam under "Enabled" and nothing under "Disabled" (so I assume it just "replaced" it?). I wonder if all my settings were preserved (on 9/13/24 I did make a backup of my option settings in a file I named "ffe Saved Options AugmentedSteam_v4.1.1.json" which I assume I could restore if needed). I tested the fix and it does work for me (THANKS). When the update is released will it automatically replace the installed beta?

@candela97
Copy link
Collaborator

Settings should persist. Temporary addons are removed when you restart FF and will also not update.

@markwr
Copy link
Author

markwr commented Sep 27, 2024

"Temporary addons are removed" ... will my release version come back at that point or will I have to reinstall it? Thanks.

@candela97
Copy link
Collaborator

Temporary addons are just temporary and don't affect the installed one, other than some limitations such as shared storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser specific Specific to a browser (or a certain version of such) bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants