-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Enter key reverted to not saving. #2057
Comments
Seems like a browser difference because it works on Chrome. |
Thanks for such a quick response. I wanted to test the fix, but Augmented Steam Version: 4.1.2 is still the newest published version at the moment. I'll need to wait for the next version before I can test the fix (unless there is a way for me to try a beta version). |
You can download a build for the linked PR here https://github.com/IsThereAnyDeal/AugmentedSteam/actions/runs/11032651093 |
I'm a bit embarrassed to admit that I don't know how to install via that link (Build Augmented Steam (firefox) / Build firefox), ie how/where to run any of those commands. Perhaps I just need to wait for an official release. Thanks anyway. |
No need to run any commands, just download a build from the Artifacts section below. To sideload on FF, enter |
Selecting any file will do.
The offical one will also be disabled when you sideload a temporary one, and it will also be removed automatically after you restart FF. |
Thank you. At the FF about:addons page, I first "Disabled" my release version of the FF Augmented Steam extension (maybe an unnecessary step) . Then I "sideloaded" the beta version. I notice that about:addons now shows Augmented Steam under "Enabled" and nothing under "Disabled" (so I assume it just "replaced" it?). I wonder if all my settings were preserved (on 9/13/24 I did make a backup of my option settings in a file I named "ffe Saved Options AugmentedSteam_v4.1.1.json" which I assume I could restore if needed). I tested the fix and it does work for me (THANKS). When the update is released will it automatically replace the installed beta? |
Settings should persist. Temporary addons are removed when you restart FF and will also not update. |
"Temporary addons are removed" ... will my release version come back at that point or will I have to reinstall it? Thanks. |
Temporary addons are just temporary and don't affect the installed one, other than some limitations such as shared storage. |
Expected Behavior
During "Update note", the [Enter] key saves the new/edited note and exits the update.
Actual Behavior
During "Update note", the [Enter] key exits the update without saving the new/edited note.
Steps to Reproduce the Problem
Specifications
NOTE: See #1288 which ended up with you implementing the ability I describe above under "Expected Behavior" (around Nov 1, 2021). That ability recently became corrupted, likely during an update.
The text was updated successfully, but these errors were encountered: