Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider refactor of query handler base to include JSON/Protobuf parsing explicitly #197

Open
ifadams opened this issue Jul 24, 2024 · 0 comments
Labels
Enhancement New features or upgrades for functionality, performance, etc Priority: Backlog Tasks that are not pressing, but to be tracked and revisited

Comments

@ifadams
Copy link
Contributor

ifadams commented Jul 24, 2024

Is your feature request related to a problem? Please describe.
Currently there is still some copy-paste work for doing the initial parse and validation of the incoming JSON, if possible we should try to generalize this to be inherited in the derived classes for better code re-use

Describe the solution you'd like
Assuming the current parsing and validation is general enough we should at a minimum move the JSON parsing and marshalling to a common base method in QueryHandler base, and will require some minor updates to derived classes (PMGD, Example Handler, and ongoing development of Neo4J handler)

Additional context
There's been discussion of generalizing around RS-Commands however, different handlers may require different signatures that are difficult to template. I will look into this, but this refactor will probably be minimal and focused around getting the JSON in order for general use in the derived classes.

@ifadams ifadams added Enhancement New features or upgrades for functionality, performance, etc Priority: Backlog Tasks that are not pressing, but to be tracked and revisited labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New features or upgrades for functionality, performance, etc Priority: Backlog Tasks that are not pressing, but to be tracked and revisited
Projects
None yet
Development

No branches or pull requests

1 participant