-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement of upload profile image #348
Comments
Hi there! Thanks for opening this issue. We appreciate your contribution to this open-source project. We aim to respond or assign your issue as soon as possible. |
@codewarnab or @rishicds can you please add label for this issue and assign this to me. |
Best of luck @shilpashingnapure |
@shilpashingnapure are you planning to add it in the registration page itself ? |
also try to make the profile picture is an optional thing probably adding a random avtar would be enough and user can change it if they want |
I don't get it this. you mean once registration is done after that we have ask user if you want to upload profile pic or not like this ? |
I guess this feature will get complicate then , for simplicity then we can just keep upload photo option for profile page only and also we are already showing default image to users in profile page so i think we don't need to add this what you think guys ? |
|
yeah it might be get complicated . but our main priority is the easiest possible reporting and if any user want to register it should be super simple i think showing a modal if they want to upload profile picture or not would be good then create a uploading section their or just redirect to profile page and show a tooltip for uplloading profile picture . let me know what are your thoughts on this |
this will be good idea , after registration we can redirect to profile page and show a tooltip for uploading |
as it is complicated task it is better to break it in multiple issues . you can do it else i will do it tonight |
now we are redirecting to the page , so i think we no need of multiple issues , we can do this in single task only. |
pls, assign this issue to me, i am a contributor at GSSOC'24. |
@shilpashingnapure hey i was just checking the paws you have added the profile picture functionality before why is the feature is coming when i click on the profile icon in profile page ? |
@rishicds have you updated the deployed branch ? |
yes @codewarnab , check in a few mins |
|
nope its working fine |
yeah but after registration you need show a modal that if user wants to upload profile pic or not if not then dont redirect else redirect it will not much hard as already their are two modals in the app you can just take the code from their so if you wan this work under one issue feel free to start working on it also we have updated the deployed branch you can test the profile picture functionality properly if you find any bugs |
okay , I will look into this |
@codewarnab @rishicds Hi , can you assign me and label for this close PR #344 and for backend PR which merged it will not get counted now 🤔 , can you tell me if you know anything about this ? |
@shilpashingnapure that pr and issue from backend repository will be transferred here and will be assigned the appropriate labels, then it will be counted :) |
for this two backend PR which merged , if possible can you assign Innovateninjas/Paws-Backend#11 , Innovateninjas/Paws-Backend#10 And Thank You so Much for clearing my doubt 😊. |
@codewarnab for this backend issue , you only added gssoc label , points label is not added , does it will count 😅? |
done added point label . do not worry you will get points for all of your contribution 😊 |
@codewarnab hi can you suggest me does this flow make sense ? video1108293007.mp4 |
Yes looking perfect |
@codewarnab Hey , today I tested the upload feature , but now its not working then i got to know in backend has some changes. |
what fix needed in the frontend anirban has given a commit see if this fix the issue you taliking about |
okay , its already done. I have not seen commit of frontend my bad. |
* enhancement of upload profile img | #348 * miskenly added comment is removed
The text was updated successfully, but these errors were encountered: