Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pythonise and generalise templates #92

Open
2 tasks
dandavies99 opened this issue Feb 10, 2022 · 1 comment
Open
2 tasks

Pythonise and generalise templates #92

dandavies99 opened this issue Feb 10, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@dandavies99
Copy link
Contributor

dandavies99 commented Feb 10, 2022

Problem: There are lots of templates that are quite similar that could be generalised into blocks that are "included" in individual templates. There are also some aspects of the code that are controlled manually in HTML but could probably be generated programatically, which is more sustainable. E.g. populating the navbar dropdowns.

Proposed solution:

  • Review HTML code and see what can be moved to python (e.g. like crispy forms) and what can be generalised.
  • Add comments to any blocks of HTML code that are not very basic.

Aha! Link: https://imperial-college-ict.aha.io/requirements/RSE-132-4

@dandavies99 dandavies99 added the enhancement New feature or request label Feb 10, 2022
This was referenced Feb 10, 2022
@AdrianDAlessandro
Copy link
Collaborator

One example was needing to manually add to the template for the filters form at the top of the experiments table template (see change in this PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants