Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Safari browser #32

Open
b5i opened this issue Oct 2, 2022 · 3 comments
Open

Support Safari browser #32

b5i opened this issue Oct 2, 2022 · 3 comments
Labels
hacktoberfest This issue is ready for hacktoberfest! help wanted Extra attention is needed

Comments

@b5i
Copy link

b5i commented Oct 2, 2022

Hello, can I do the work to convert this extension to it is compatible with Apple's Safari engine ?

@ImMattDavison
Copy link
Owner

This sounds like a great idea, can you make sure it is also in this repository?

@ImMattDavison ImMattDavison added hacktoberfest This issue is ready for hacktoberfest! help wanted Extra attention is needed labels Oct 2, 2022
@b5i
Copy link
Author

b5i commented Oct 17, 2022

It seems that the extension is designed only for chrome (I’ve seen on the Firefox issue) so it won’t work to convert the app like that (seen in Safari’s console and figured out that it wasn’t able to now what chrome.attributes was).

@ImMattDavison
Copy link
Owner

It seems that the extension is designed only for chrome (I’ve seen on the Firefox issue) so it won’t work to convert the app like that (seen in Safari’s console and figured out that it wasn’t able to now what chrome.attributes was).

Pretty sure it just needs MV2 and browser API rather than chrome API - MV3 and MV2 versions can be put into different dirs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest This issue is ready for hacktoberfest! help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants