Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it more obvious that shared-mime-info may be needed #8

Open
aperezdc opened this issue Jan 7, 2019 · 1 comment
Open

Make it more obvious that shared-mime-info may be needed #8

aperezdc opened this issue Jan 7, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@aperezdc
Copy link
Member

aperezdc commented Jan 7, 2019

See: Igalia/cog#73 (comment)
@aperezdc aperezdc added enhancement New feature or request good first issue Good for newcomers labels Jan 7, 2019
@aperezdc
Copy link
Member Author

aperezdc commented Jan 7, 2019

Probably a good way to go is to add a comment in wpewebkit/Config.in which is displayed in the configuration menus when the shared-mime-info package was not selected by the user.

I would prefer to not select the package unconditionally because it takes ≥5 MiB and it is not strictly needed in many cases (for example, usages which only load resources from the network don't need the package installed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aperezdc