Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss ViewController on ScrollView scroll / pan gesture #125

Open
Ankish opened this issue Dec 19, 2017 · 9 comments
Open

Dismiss ViewController on ScrollView scroll / pan gesture #125

Ankish opened this issue Dec 19, 2017 · 9 comments

Comments

@Ankish
Copy link

Ankish commented Dec 19, 2017

  1. Dismiss viewcontroller on pan of scrollview (tableview /collectionview) .
    https://github.com/sgr-ksmt/PullToDismiss

  2. Also, the UITableviewcontroller can be the child view controller of the view controller which we are presenting. Dismissing the complete viewcontroller on pan similar to 1. Though that should not affect, just a note.

@danlozano
Copy link
Contributor

Sorry. Been really busy with work.

Will get a couple of weeks of for the holidays and will catch up on issues and pull requests. Thanks for your patience.

@Ankish
Copy link
Author

Ankish commented Apr 10, 2018

@danlozano : any plan to update this. Since all default controls have the gesture dismissing now. It would be very cool to integrate this. I dont see any other library achieving this well.
One of it is : https://github.com/HarshilShah/DeckTransition . It does not have custom height presentation.

@Ankish Ankish changed the title Dismiss ViewController on scroll Dismiss ViewController on scroll / pan gesture Apr 17, 2018
@danlozano
Copy link
Contributor

This issue is now officially on the road-map, as this is something that has become standard issue now with the iPhone X and many stock iOS apps (Music, Podcasts).

I will start working on this, if anyone has any ideas/suggestions or want's to help out via a PR, you are very welcome.

@danlozano danlozano changed the title Dismiss ViewController on scroll / pan gesture Dismiss ViewController on ScrollView scroll / pan gesture Apr 25, 2018
@patthehuman
Copy link

I posted about this a while ago. If you disable vertical scrolling from scrollviews (stop scrolling when it reaches 0.0) and enable simultaneous gesture recognizers it should work

@ergunkocak
Copy link

https://asciiwwdc.com/2014/sessions/235
I could not find the video i guess apple removed it. I can send over wetransfer the video in case you like. It helped me a lot

@vfumin
Copy link

vfumin commented Dec 8, 2020

Has any progress on this task?

@FrankWuoO
Copy link

Looking forward to this enhancement.

@patthehuman
Copy link

patthehuman commented Feb 24, 2021 via email

@FrankWuoO
Copy link

Oh... Okay.
Thanks for your message. 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants