diff --git a/cmake/compiler_features.cmake b/cmake/compiler_features.cmake index 084693d..566707b 100644 --- a/cmake/compiler_features.cmake +++ b/cmake/compiler_features.cmake @@ -1,3 +1,5 @@ -add_library(compiler_features INTERFACE) +if(NOT TARGET compiler_features) + add_library(compiler_features INTERFACE) -target_compile_features(compiler_features INTERFACE cxx_std_20) \ No newline at end of file + target_compile_features(compiler_features INTERFACE cxx_std_20) +endif() \ No newline at end of file diff --git a/cmake/compiler_warnings.cmake b/cmake/compiler_warnings.cmake index 7e143f7..2a242ce 100644 --- a/cmake/compiler_warnings.cmake +++ b/cmake/compiler_warnings.cmake @@ -1,56 +1,58 @@ -add_library(compiler_warnings INTERFACE) +if(NOT TARGET compiler_warnings) + add_library(compiler_warnings INTERFACE) -# cmake-format: off + # cmake-format: off -if (MSVC) - target_compile_options(compiler_warnings INTERFACE - /WX # treat warnings as errors - /W4 # warning level 4 - /permissive- # standards conformance https://docs.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=vs-2017 - /w14242 # 'identfier': conversion from 'type1' to 'type1', possible loss of data - /w14254 # 'operator': conversion from 'type1:field_bits' to 'type2:field_bits', possible loss of data - /w14263 # 'function': member function does not override any base class virtual member function - /w14265 # 'classname': class has virtual functions, but destructor is not virtual instances of this class may not be destructed correctly - /w14287 # 'operator': unsigned/negative constant mismatch - /we4289 # nonstandard extension used: 'variable': loop control variable declared in the for-loop is used outside the for-loop scope - /w14296 # 'operator': expression is always 'boolean_value' - /w14296 # 'operator': expression is always 'boolean_value' - /w14311 # 'variable': pointer truncation from 'type1' to 'type2' - /w14545 # expression before comma evaluates to a function which is missing an argument list - /w14546 # function call before comma missing argument list - /w14547 # 'operator': operator before comma has no effect; expected operator with side-effect - /w14549 # 'operator': operator before comma has no effect; did you intend 'operator'? - /w14555 # expression has no effect; expected expression with side-effect - /w14619 # pragma warning: there is no warning number 'number' - /w14640 # Enable warning on thread un-safe static member initialization - /w14826 # Conversion from 'type1' to 'type_2' is sign-extended. This may cause unexpected runtime behavior. - /w14905 # wide string literal cast to 'LPSTR' - /w14906 # string literal cast to 'LPWSTR' - /w14928 - - /wd4201 # nonstandard extension used : nameless struct/union - ) -else() - target_compile_options(compiler_warnings INTERFACE - -Wall # reasonable and standard - -Wextra # reasonable and standard - -Wshadow # warn the user if a variable declaration shadows one from a parent context - -Wnon-virtual-dtor # warn the user if a class with virtual functions has a non-virtual destructor. This helps catch hard to track down memory errors - -Wold-style-cast # warn for c-style casts - -Wcast-align # warn for potential performance problem casts - -Wunused # warn on anything being unused - -Woverloaded-virtual # warn if you overload (not override) a virtual function - -Wpedantic # warn if non-standard C++ is used - -Wconversion # warn on type conversions that may lose data - -Wsign-conversion # warn on sign conversions - -Wmisleading-indentation# warn if indentation implies blocks where blocks do not exist - -Wduplicated-cond # warn if if / else chain has duplicated conditions - -Wduplicated-branches # warn if if / else branches have duplicated code - -Wlogical-op # warn about logical operations being used where bitwise were probably wanted - -Wnull-dereference # warn if a null dereference is detected - -Wuseless-cast # warn if you perform a cast to the same type - -Wdouble-promotion # warn if float is implicit promoted to double - -Wformat=2) # warn on security issues around functions that format output (ie printf) -endif() + if (MSVC) + target_compile_options(compiler_warnings INTERFACE + /WX # treat warnings as errors + /W4 # warning level 4 + /permissive- # standards conformance https://docs.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=vs-2017 + /w14242 # 'identfier': conversion from 'type1' to 'type1', possible loss of data + /w14254 # 'operator': conversion from 'type1:field_bits' to 'type2:field_bits', possible loss of data + /w14263 # 'function': member function does not override any base class virtual member function + /w14265 # 'classname': class has virtual functions, but destructor is not virtual instances of this class may not be destructed correctly + /w14287 # 'operator': unsigned/negative constant mismatch + /we4289 # nonstandard extension used: 'variable': loop control variable declared in the for-loop is used outside the for-loop scope + /w14296 # 'operator': expression is always 'boolean_value' + /w14296 # 'operator': expression is always 'boolean_value' + /w14311 # 'variable': pointer truncation from 'type1' to 'type2' + /w14545 # expression before comma evaluates to a function which is missing an argument list + /w14546 # function call before comma missing argument list + /w14547 # 'operator': operator before comma has no effect; expected operator with side-effect + /w14549 # 'operator': operator before comma has no effect; did you intend 'operator'? + /w14555 # expression has no effect; expected expression with side-effect + /w14619 # pragma warning: there is no warning number 'number' + /w14640 # Enable warning on thread un-safe static member initialization + /w14826 # Conversion from 'type1' to 'type_2' is sign-extended. This may cause unexpected runtime behavior. + /w14905 # wide string literal cast to 'LPSTR' + /w14906 # string literal cast to 'LPWSTR' + /w14928 + + /wd4201 # nonstandard extension used : nameless struct/union + ) + else() + target_compile_options(compiler_warnings INTERFACE + -Wall # reasonable and standard + -Wextra # reasonable and standard + -Wshadow # warn the user if a variable declaration shadows one from a parent context + -Wnon-virtual-dtor # warn the user if a class with virtual functions has a non-virtual destructor. This helps catch hard to track down memory errors + -Wold-style-cast # warn for c-style casts + -Wcast-align # warn for potential performance problem casts + -Wunused # warn on anything being unused + -Woverloaded-virtual # warn if you overload (not override) a virtual function + -Wpedantic # warn if non-standard C++ is used + -Wconversion # warn on type conversions that may lose data + -Wsign-conversion # warn on sign conversions + -Wmisleading-indentation# warn if indentation implies blocks where blocks do not exist + -Wduplicated-cond # warn if if / else chain has duplicated conditions + -Wduplicated-branches # warn if if / else branches have duplicated code + -Wlogical-op # warn about logical operations being used where bitwise were probably wanted + -Wnull-dereference # warn if a null dereference is detected + -Wuseless-cast # warn if you perform a cast to the same type + -Wdouble-promotion # warn if float is implicit promoted to double + -Wformat=2) # warn on security issues around functions that format output (ie printf) + endif() -# cmake-format: on + # cmake-format: on +endif() \ No newline at end of file diff --git a/dubu_serialize_test/CMakeLists.txt b/dubu_serialize_test/CMakeLists.txt index f9af32e..c315927 100644 --- a/dubu_serialize_test/CMakeLists.txt +++ b/dubu_serialize_test/CMakeLists.txt @@ -8,8 +8,6 @@ set(src_files add_executable(${target_name} ${src_files}) target_link_libraries(${target_name} - gtest - gmock gmock_main dubu_serialize)