Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: LEAP-1467: Adapt Textarea result container to new style #6413

Merged
merged 14 commits into from
Sep 25, 2024
Merged

feat: LEAP-1467: Adapt Textarea result container to new style #6413

merged 14 commits into from
Sep 25, 2024

Conversation

ricardoantoniocm
Copy link
Contributor

@ricardoantoniocm ricardoantoniocm commented Sep 20, 2024 •
edited
Loading

Description

Improves the result containers and corresponding action buttons of the TextArea tag to match the new look and feel

Testing

  1. Create a project and set up a labeling configuration with the TextArea tag with the parameters editable="true" and transcription="false"
  2. Import any text data
  3. Start labeling
  4. Enter any text on the TextArea box and press Enter or click on the Add button
  5. Notice the results container matches the new look and feel
  6. Notice the icon buttons match the application's general look and feel

Screenshots

Before:
image

After:
image

image image

@ricardoantoniocm
* Improves the look and feel of the Textbox results container to matc…
0b4f7ef 
…h the current brand style.

* Moves the edit button outside the container.
* Ensure result containers expand the full width so that buttons are aligned on the right.
* Adds tooltips to controls.
@netlify Netlify
Copy link

netlify bot commented Sep 20, 2024 •
edited
Loading

✅ Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 9f6eed3
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66f2d37bd11c4200097f441a

@netlify Netlify
Copy link

netlify bot commented Sep 20, 2024 •
edited
Loading

✅ Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 9f6eed3
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66f2d37b383074000837dfa0

@github-actions github-actions bot added the feat label Sep 20, 2024
yyassi-heartex
yyassi-heartex approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@yyassi-heartex yyassi-heartex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! one thing to call out for the Tokenization initiative is we have 4px, 8px, 12px and 24px reused through out the application for border radius, gap and spacing related styles so it would be good to be changed to a css variable as part of that initiative - what do you think?

bmartel
bmartel approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@bmartel bmartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, I applied the suggestion for spacing for you so we can merge when ready 💪

@ricardoantoniocm
Copy link
Contributor Author

looks good! one thing to call out for the Tokenization initiative is we have 4px, 8px, 12px and 24px reused through out the application for border radius, gap and spacing related styles so it would be good to be changed to a css variable as part of that initiative - what do you think?

Thank you for pointing this out. I'll introduce these variables.

@ricardoantoniocm
* Replaces icons for edit and delete actions
952059d 
* Improves spacing between results container and between icons
* Adds button look and feel to actions, including negative colors for delete action
* Replaces tooltip with the one used across the app
* Refreshes style for selected and highlighted modes
* Improved border radius of result container
@ricardoantoniocm
* Fixes currentColor casing on SVGs
e07b41d
@ricardoantoniocm
* Replaces Tooltip, Element components with Editor Button
b5095c8 
* Renames TextAreaRegion.module.scss to TextAreaRegion.scss
* Refactors CSS to avoid  overrides, removes unnecessary styles
@ricardoantoniocm
* Imports BEM
a08b68b
yyassi-heartex
yyassi-heartex approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@yyassi-heartex yyassi-heartex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wanted confirmation that things surrounding the issue we saw earlier are still good - other wise ✅

@ricardoantoniocm
Copy link
Contributor Author

ricardoantoniocm commented Sep 23, 2024 •
edited
Loading

just wanted confirmation that things surrounding the issue we saw earlier are still good - other wise ✅

They seem to be applied correctly @yyassi-heartex :
image

@ricardoantoniocm ricardoantoniocm self-assigned this Sep 23, 2024
bmartel
bmartel approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@bmartel bmartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, had same observation about the need for !important on the .mark class, but will approve based on the resolution/explanation.

@ricardoantoniocm ricardoantoniocm merged commit 7d1c6d4 into develop Sep 25, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyassi-heartex yyassi-heartex yyassi-heartex approved these changes

@hlomzik hlomzik hlomzik approved these changes

@bmartel bmartel bmartel approved these changes

@vladimirheartex vladimirheartex vladimirheartex approved these changes

Assignees

@ricardoantoniocm ricardoantoniocm

Labels
Confirmed feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ricardoantoniocm @hlomzik @bmartel @vladimirheartex @yyassi-heartex @robot-ci-heartex