Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LEAP-1448: Add support of rejected+cancelled in skipped queue #6403

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

triklozoid
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

@github-actions github-actions bot added the feat label Sep 18, 2024
Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit f3eb63e
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66f2e706f26d350008b3ef79

Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit f3eb63e
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66f2e706df80680008f2fbf9

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.62%. Comparing base (0d07360) to head (f3eb63e).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/tasks/models.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6403   +/-   ##
========================================
  Coverage    76.61%   76.62%           
========================================
  Files          169      169           
  Lines        13746    13756   +10     
========================================
+ Hits         10532    10540    +8     
- Misses        3214     3216    +2     
Flag Coverage Δ
pytests 76.62% <88.23%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@triklozoid triklozoid changed the title feat: Add support of rejected+cancelled in skipped queue feat: LEAP-1448: Add support of rejected+cancelled in skipped queue Sep 20, 2024
@triklozoid
Copy link
Contributor Author

triklozoid commented Sep 23, 2024

/git merge develop

Workflow run
Successfully merged: create mode 100644 web/libs/editor/tests/integration/e2e/linking_modes/to_comments.cy.ts

@triklozoid
Copy link
Contributor Author

triklozoid commented Sep 24, 2024

/git merge develop

Workflow run
Successfully merged: create mode 100644 web/libs/editor/src/stores/Comment/Anchor.js

@triklozoid triklozoid merged commit cb0832c into develop Sep 24, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants